New issue
Advanced search Search tips

Issue 842797 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:8997


Sign in to add a comment

TBR does not work for some changes

Project Member Reported by danakj@chromium.org, May 11 2018

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/1055804 could not pass the presubmit even though it was TBR'd.

So gerrit isn't telling things they are TBR'd or TBR is breaking somehow.
 

Comment 1 by danakj@chromium.org, May 11 2018

It claimed (twice):

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    android_webview/browser/DEPS
    content/DEPS
    content/renderer/BUILD.gn
    content/renderer/DEPS
    content/renderer/browser_plugin/browser_plugin.cc
    content/renderer/child_frame_compositing_helper.cc
    content/renderer/child_frame_compositing_helper_unittest.cc
    content/renderer/gpu/render_widget_compositor.cc
    content/renderer/gpu/render_widget_compositor.h
    content/renderer/media/stream/webmediaplayer_ms.cc
    content/renderer/media/stream/webmediaplayer_ms.h
    content/renderer/pepper/pepper_compositor_host.cc
    content/renderer/pepper/pepper_plugin_instance_impl.cc
    content/renderer/render_frame_proxy.cc
    content/renderer/render_thread_impl.cc
    content/renderer/render_widget_fullscreen_pepper.cc
    content/renderer/renderer_blink_platform_impl.cc
    content/renderer/renderer_blink_platform_impl.h
    content/shell/test_runner/BUILD.gn
    content/shell/test_runner/test_plugin.cc
    content/test/DEPS
    content/test/test_blink_web_unit_test_support.cc
    content/test/test_blink_web_unit_test_support.h
    media/blink/BUILD.gn
    media/blink/DEPS
    media/blink/webmediaplayer_impl.cc
    media/blink/webmediaplayer_impl.h
    media/blink/webmediaplayer_impl_unittest.cc
    ui/snapshot/DEPS
    ui/views/mus/DEPS
Note that TBR does not apply to changes that affect OWNERS files.
Missing LGTM from an OWNER for these files:
    android_webview/browser/DEPS
    content/DEPS
    content/renderer/BUILD.gn
    content/renderer/DEPS
    content/renderer/browser_plugin/browser_plugin.cc
    content/renderer/child_frame_compositing_helper.cc
    content/renderer/child_frame_compositing_helper_unittest.cc
    content/renderer/gpu/render_widget_compositor.cc
    content/renderer/gpu/render_widget_compositor.h
    content/renderer/media/stream/webmediaplayer_ms.cc
    content/renderer/media/stream/webmediaplayer_ms.h
    content/renderer/pepper/pepper_compositor_host.cc
    content/renderer/pepper/pepper_plugin_instance_impl.cc
    content/renderer/render_frame_proxy.cc
    content/renderer/render_thread_impl.cc
    content/renderer/render_widget_fullscreen_pepper.cc
    content/renderer/renderer_blink_platform_impl.cc
    content/renderer/renderer_blink_platform_impl.h
    content/shell/test_runner/BUILD.gn
    content/shell/test_runner/test_plugin.cc
    content/test/DEPS
    content/test/test_blink_web_unit_test_support.cc
    content/test/test_blink_web_unit_test_support.h
    media/blink/BUILD.gn
    media/blink/DEPS
    media/blink/webmediaplayer_impl.cc
    media/blink/webmediaplayer_impl.h
    media/blink/webmediaplayer_impl_unittest.cc
    ui/snapshot/DEPS
    ui/views/mus/DEPS
Note that TBR does not apply to changes that affect OWNERS files.

Comment 2 by danakj@chromium.org, May 11 2018

I've got a TBR=jam line though, who is in src/OWNERS via src/ENG_REVIEW_OWNERS

Comment 3 by kaspern@google.com, May 14 2018

TBR functionality is added by a Chromium-specific plugin.

Comment 4 by kaspern@google.com, May 14 2018

Labels: -Type-Bug -Priority-3

Comment 5 by kaspern@google.com, May 14 2018

Project: chromium
Moved issue gerrit:8997 to now be  issue chromium:842797 .

Comment 6 by kaspern@google.com, May 14 2018

Components: Infra>Codereview>Gerrit
Status: WontFix (was: New)
This is working as intended. As noted in the output provided above:

"Note that TBR does not apply to changes that affect OWNERS files." 

Basically, our checks do not allow TBR changes that change OWNERS files. And I confirmed that the CL in question did change OWNERS files.

Sign in to add a comment