New issue
Advanced search Search tips

Issue 842789 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

Show a throbber in Harmony Cast Dialog when casting

Project Member Reported by taku...@chromium.org, May 14 2018

Issue description

The sink that the user is attempting to cast to should show a throbber to indicate that an attempt is in progress.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a226d3d82bdd5a323ae4a4aedf307dae2d6c638c

commit a226d3d82bdd5a323ae4a4aedf307dae2d6c638c
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Sat Jun 02 01:27:24 2018

[Harmony Cast Dialog] Show a throbber when connecting to a sink

While there is a request to start Casting, make the state of the
corresponding sink CONNECTING so that the UI would show a throbber for
it.

MRUIBase now tracks the sink ID for the current route request (contained
in the RouteRequest struct), and MRViewsUI sets a sink's state to CONNECTING
if the sink IDs match.

Bug:  842789 
Change-Id: Id63d2fb65b34d2165dd9445cff3ef884a3a42587
Reviewed-on: https://chromium-review.googlesource.com/1074270
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563900}
[modify] https://crrev.com/a226d3d82bdd5a323ae4a4aedf307dae2d6c638c/chrome/browser/ui/media_router/media_router_ui_base.cc
[modify] https://crrev.com/a226d3d82bdd5a323ae4a4aedf307dae2d6c638c/chrome/browser/ui/media_router/media_router_ui_base.h
[modify] https://crrev.com/a226d3d82bdd5a323ae4a4aedf307dae2d6c638c/chrome/browser/ui/views/media_router/media_router_views_ui.cc
[modify] https://crrev.com/a226d3d82bdd5a323ae4a4aedf307dae2d6c638c/chrome/browser/ui/views/media_router/media_router_views_ui.h
[modify] https://crrev.com/a226d3d82bdd5a323ae4a4aedf307dae2d6c638c/chrome/browser/ui/views/media_router/media_router_views_ui_unittest.cc
[modify] https://crrev.com/a226d3d82bdd5a323ae4a4aedf307dae2d6c638c/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/a226d3d82bdd5a323ae4a4aedf307dae2d6c638c/chrome/browser/ui/webui/media_router/media_router_ui.h

Status: Fixed (was: Assigned)

Sign in to add a comment