New issue
Advanced search Search tips

Issue 842787 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

Make the Harmony Cast Dialog support casting local files

Project Member Reported by taku...@chromium.org, May 14 2018

Issue description

The feature is in MediaRouterUI class, and needs to be moved to MediaRouterUIBase to be shared with the Views dialog.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa48f0766ec6132db769905ec5d6d518558cde3d

commit fa48f0766ec6132db769905ec5d6d518558cde3d
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Wed Jun 20 17:16:22 2018

Move local file casting code from MediaRouterUI to MediaRouterUIBase

This CL moves local file casting code to MRUIBase so that it can be used
by MediaRouterViewsUI as well. This also makes MRViewsUI start casting
once a file is selected in the file picker.

The Views dialog still cannot cast local files after this CL, because
we still need to make it stay open even when the file picker is in
focus.

Bug:  842787 
Change-Id: I6ac2d2863785c895b4b515856b942409326e577d
Reviewed-on: https://chromium-review.googlesource.com/1087840
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568889}
[modify] https://crrev.com/fa48f0766ec6132db769905ec5d6d518558cde3d/chrome/browser/ui/media_router/media_router_ui_base.cc
[modify] https://crrev.com/fa48f0766ec6132db769905ec5d6d518558cde3d/chrome/browser/ui/media_router/media_router_ui_base.h
[modify] https://crrev.com/fa48f0766ec6132db769905ec5d6d518558cde3d/chrome/browser/ui/views/media_router/media_router_views_ui.cc
[modify] https://crrev.com/fa48f0766ec6132db769905ec5d6d518558cde3d/chrome/browser/ui/views/media_router/media_router_views_ui.h
[modify] https://crrev.com/fa48f0766ec6132db769905ec5d6d518558cde3d/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/fa48f0766ec6132db769905ec5d6d518558cde3d/chrome/browser/ui/webui/media_router/media_router_ui.h

Comment 2 by mfo...@chromium.org, Jun 25 2018

Keeping for M-69 so as not to launch with a perceived regression.
However, usage of this feature is very low...
Blocking: -754101
Labels: -M-69 M-70
Per priority of [Sources] behavior this is non-blocking for M69
Cc: powerb@chromium.org
Labels: -M-70 Target-71 M-71
Labels: -M-71 -Target-71 Target-72 M-72
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86

commit 7a07736b8c77429b52c74b5d5db76d4a6e5b6f86
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Mon Nov 12 21:42:19 2018

[Harmony Cast Dialog] Add local files as a source

Add local files as one of the options in the sources dropdown. When it
is selected, a file picker dialog is opened via MediaRouterViewsUI. After
selecting a file, the user can select a sink to start casting.

The dialog has a functionality to close itself on blur, which will be
disabled while a file picker is open, and when the file is opened in a
new tab, to prevent the dialog from closing at those moments.

Bug:  842787 
Change-Id: I3e9ebf0b1958c026f418111feb792a9d94fce533
Reviewed-on: https://chromium-review.googlesource.com/c/1299657
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607337}
[modify] https://crrev.com/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86/chrome/browser/ui/media_router/cast_dialog_controller.h
[modify] https://crrev.com/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86/chrome/browser/ui/views/media_router/cast_dialog_view.cc
[modify] https://crrev.com/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86/chrome/browser/ui/views/media_router/cast_dialog_view.h
[modify] https://crrev.com/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86/chrome/browser/ui/views/media_router/cast_dialog_view_unittest.cc
[modify] https://crrev.com/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86/chrome/browser/ui/views/media_router/media_router_views_ui.cc
[modify] https://crrev.com/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86/chrome/browser/ui/views/media_router/media_router_views_ui.h

Status: Fixed (was: Started)

Sign in to add a comment