Make the Harmony Cast Dialog support casting local files |
|||||||
Issue descriptionThe feature is in MediaRouterUI class, and needs to be moved to MediaRouterUIBase to be shared with the Views dialog.
,
Jun 25 2018
Keeping for M-69 so as not to launch with a perceived regression. However, usage of this feature is very low...
,
Jun 27 2018
Per priority of [Sources] behavior this is non-blocking for M69
,
Aug 2
,
Aug 17
,
Oct 15
,
Nov 8
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86 commit 7a07736b8c77429b52c74b5d5db76d4a6e5b6f86 Author: Takumi Fujimoto <takumif@chromium.org> Date: Mon Nov 12 21:42:19 2018 [Harmony Cast Dialog] Add local files as a source Add local files as one of the options in the sources dropdown. When it is selected, a file picker dialog is opened via MediaRouterViewsUI. After selecting a file, the user can select a sink to start casting. The dialog has a functionality to close itself on blur, which will be disabled while a file picker is open, and when the file is opened in a new tab, to prevent the dialog from closing at those moments. Bug: 842787 Change-Id: I3e9ebf0b1958c026f418111feb792a9d94fce533 Reviewed-on: https://chromium-review.googlesource.com/c/1299657 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#607337} [modify] https://crrev.com/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86/chrome/browser/ui/media_router/cast_dialog_controller.h [modify] https://crrev.com/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86/chrome/browser/ui/views/media_router/cast_dialog_view.cc [modify] https://crrev.com/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86/chrome/browser/ui/views/media_router/cast_dialog_view.h [modify] https://crrev.com/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86/chrome/browser/ui/views/media_router/cast_dialog_view_unittest.cc [modify] https://crrev.com/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86/chrome/browser/ui/views/media_router/media_router_views_ui.cc [modify] https://crrev.com/7a07736b8c77429b52c74b5d5db76d4a6e5b6f86/chrome/browser/ui/views/media_router/media_router_views_ui.h
,
Nov 15
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 20 2018