Network indicator is still displayed even after download is stopped. |
||||||||
Issue descriptionApp Version: 67.0.3396.46 beta iOS Version: 11.4 beta#4, 10.3.3 Device: iPhone6s, iPhone7Plus, iPad URL: https://www.thinkbroadband.com/download Steps to reproduce: 1. Launch Google Chrome 2. Navigate to the above downloads url and download 1GB file 3. Once the download infobar is displayed, tap Download 4. While the download is in progress, tap on another downloadable file from the same page 5. Tap on Stop in the alert displayed. Observed results: Observe that existing download is stopped, but network indicator is displayed in status bar forever. Expected results: Network indicator should go away as soon as the download is stopped. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NO, Safari: NO Bug reproducible on current stable build (App Version, iOS Version): M66 New feature Bug reproducible on the current beta channel build (App Version, iOS Version): M67 Yes
,
May 14 2018
Not related to network type. Agree that not RBS. Fix is here: crrev.com/c/1058378
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44d4d2b99af0b76adc1c9678b70fc3f89805727e commit 44d4d2b99af0b76adc1c9678b70fc3f89805727e Author: Eugene But <eugenebut@google.com> Date: Tue May 15 14:35:54 2018 Stop progress indicator if download is replaced. Bug: 842781 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I001fbaf3d100e173252aacde7b3cc4f28e28fa31 Reviewed-on: https://chromium-review.googlesource.com/1058378 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#558699} [modify] https://crrev.com/44d4d2b99af0b76adc1c9678b70fc3f89805727e/ios/chrome/browser/download/download_manager_tab_helper.mm [modify] https://crrev.com/44d4d2b99af0b76adc1c9678b70fc3f89805727e/ios/chrome/browser/download/download_manager_tab_helper_unittest.mm
,
May 15 2018
The fix is safe and I believe we should cherry-pick it.
,
May 15 2018
This bug requires manual review: Less than 10 days to go before AppStore submit on M67 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2018
Both comment #! and #2 say this isn't release blocking. Why should this be merged into 67 (stable cut is next Thursday) instead of waiting for 68?
,
May 15 2018
The fix is safe, the code is written behind New Download Manager flag (which we may not even ramp up to 100%) and the bug is annoying (network activity indicator does not stop). We can definitely wait for M68.
,
May 15 2018
The network indicator constantly spinning is something I would like to see us take a fix for, even if it is a bit convoluted to get into this situation. It gives the user the sense that something is still going on that they can't stop, which could make them think we're using more data or draining more battery than we actually are, or just feel not in control.
,
May 15 2018
Eugene: This fix is completely behind the new download manager flag? So if there is a major issue with this cl, we may have to turn off the entire download manager feature? I don't anticipate this but just want to understand correctly.
,
May 15 2018
Correct, this code is completely behind the flag.
,
May 15 2018
Ok, approved. Please merge asap.
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb729028b2fc1bde0dcb1ded4c2f731a7a552424 commit fb729028b2fc1bde0dcb1ded4c2f731a7a552424 Author: Eugene But <eugenebut@google.com> Date: Tue May 15 23:32:55 2018 Stop progress indicator if download is replaced. TBR=eugenebut@google.com (cherry picked from commit 44d4d2b99af0b76adc1c9678b70fc3f89805727e) Bug: 842781 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I001fbaf3d100e173252aacde7b3cc4f28e28fa31 Reviewed-on: https://chromium-review.googlesource.com/1058378 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#558699} Reviewed-on: https://chromium-review.googlesource.com/1060079 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#611} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/fb729028b2fc1bde0dcb1ded4c2f731a7a552424/ios/chrome/browser/download/download_manager_tab_helper.mm [modify] https://crrev.com/fb729028b2fc1bde0dcb1ded4c2f731a7a552424/ios/chrome/browser/download/download_manager_tab_helper_unittest.mm
,
May 22 2018
Verified in iPhone 7(iOS 10.3.3), iPad (iOS 11.3) and iPad Air(iOS 10.3.3) Followed the steps mentioned in comment#0, network indicator goes away as soon as the download is stopped.
,
May 22 2018
Missed to mention the tested build in comment #13, verified on 68.0.3437.0 Canary
,
May 23 2018
Verified in 67.0.3396.57 Beta on iPhone 6s plus(iOS 10.3.3), iPhone 8plus(iOS 11.4 Beta), iPad (iOS 11.3.1) Followed the steps mentioned in comment#0, network indicator goes away as soon as the download is stopped. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pkl@chromium.org
, May 14 2018Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)