New issue
Advanced search Search tips

Issue 842778 link

Starred by 2 users
Status: Fixed
Owner:
taku...@chromium.org
Closed: May 2018
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

Don't show the cloud pseudo-sink in Harmony Cast Dialog

Project Member Reported by taku...@chromium.org, May 14 2018 
The pseudo-sink is used by the WebUI dialog to show a search bar, but it's not used in the Views dialog. So it should not be shown at all.
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c79c44872a5537642fd68e4c24b4a0b8103a6fd2

commit c79c44872a5537642fd68e4c24b4a0b8103a6fd2
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Wed May 30 22:34:18 2018

Filter out pseudo sink from Harmony Cast Dialog

Make MRViewsUI filter out pseudo sink, since it is not used in the
Views dialog and should not show up on the sink list.

Bug:  842778 
Change-Id: Icb7b5197bfcf15b7abd14389025e16f2d6391f4e
Reviewed-on: https://chromium-review.googlesource.com/1070494
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563034}
[modify] https://crrev.com/c79c44872a5537642fd68e4c24b4a0b8103a6fd2/chrome/browser/ui/media_router/media_router_ui_base.h
[modify] https://crrev.com/c79c44872a5537642fd68e4c24b4a0b8103a6fd2/chrome/browser/ui/views/media_router/media_router_views_ui.cc
[modify] https://crrev.com/c79c44872a5537642fd68e4c24b4a0b8103a6fd2/chrome/browser/ui/views/media_router/media_router_views_ui.h
[modify] https://crrev.com/c79c44872a5537642fd68e4c24b4a0b8103a6fd2/chrome/browser/ui/views/media_router/media_router_views_ui_unittest.cc

Comment 2 by taku...@chromium.org, May 30 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment