New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842747 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature

Blocked on:
issue 842408
issue 847998

Blocking:
issue 693090



Sign in to add a comment

Increase default CQ test coverage for ANGLE's OpenGL back-end

Project Member Reported by jmad...@chromium.org, May 14 2018

Issue description

In  issue 842408 , it seems as though a linker change broke the GL-back end because of a difference in handling using an incorrect Window proc in ANGLE. Going forward if we're shipping the GL back-end with issue 693090 we should ensure that CLs that break the GL-back end are caught on the CQ. This could be done a few ways, listed in increasing order of CQ testing time:

- add the optional bots to the extra bots steps of more directories, like those for compiler changes
- add a basic "does this turn on" test for the GL back-end to the main CQ
- add the GL/Passthrough WebGL 1 tests to the Windows main CQ

 

Comment 1 by kbr@chromium.org, May 31 2018

Blockedon: 847998
I think the simple thing here is to have a browser_test that just checks that --use-angle=gl doesn't crash (just booting angle and doing nothing else). That'll give us a pretty solid "are things completely busted?" check without requiring a ton of work, i.e. option 2.h
(ignore the spurious trailing h)

Sign in to add a comment