New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842742 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[PIP] Show icon on tab when in Picture-in-Picture mode

Project Member Reported by apaci...@chromium.org, May 14 2018

Issue description

Show the "Picture-in-Picture" icon in the initiator tab when we are in Picture-in-Picture mode.

See attached screenshot for example with audio.
 
Screenshot from 2018-05-14 09-42-50.png
3.0 KB View Download

Comment 1 by sawtelle@google.com, May 25 2018

Description: Show this description

Comment 2 by sawtelle@google.com, May 25 2018

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7333a897cef118f860fb4269feefb93465379d8

commit a7333a897cef118f860fb4269feefb93465379d8
Author: sawtelle <sawtelle@google.com>
Date: Thu May 31 02:36:36 2018

[Picture in Picture] Adding in-tab icon when playing Picture in Picture

This change will add an icon on the tab that appears when a user
is playing a video in picture-in-picture mode, similar to what
exists currently with audio playing and other similar features.

Per discussion, this icon will take precedent only over the audio
playing and audio_muted icons, while others (bluetooth, usb
connected, etc.) will stay at a higher level for security concerns.

Bug:  842742 
Change-Id: I9d8d7bf7764b156054838ffb5b02116fd78fbc38
Reviewed-on: https://chromium-review.googlesource.com/1068109
Commit-Queue: Steven Sawtelle <sawtelle@google.com>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563128}
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/chrome/app/generated_resources.grd
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/chrome/app/vector_icons/BUILD.gn
[add] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/chrome/app/vector_icons/picture_in_picture_alt.icon
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/chrome/browser/themes/theme_properties.h
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/chrome/browser/ui/cocoa/tabs/tab_view.mm
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/chrome/browser/ui/tabs/tab_utils.cc
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/chrome/browser/ui/tabs/tab_utils.h
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/chrome/browser/ui/views/tabs/tab_unittest.cc
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/a7333a897cef118f860fb4269feefb93465379d8/content/public/browser/web_contents.h

Labels: Merge-Request-68
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 1 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: There is .grd file changes and we are only 52 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-68 Merge-Approved-68
Approved- branch:3440
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 5 2018

Cc: abdulsyed@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 5 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a419186d3e8fe4a6065f13ccf845e91cd643374

commit 0a419186d3e8fe4a6065f13ccf845e91cd643374
Author: sawtelle <sawtelle@google.com>
Date: Tue Jun 05 18:49:14 2018

[Picture in Picture] Adding in-tab icon when playing Picture in Picture

This change will add an icon on the tab that appears when a user
is playing a video in picture-in-picture mode, similar to what
exists currently with audio playing and other similar features.

Per discussion, this icon will take precedent only over the audio
playing and audio_muted icons, while others (bluetooth, usb
connected, etc.) will stay at a higher level for security concerns.

Bug:  842742 
Change-Id: I9d8d7bf7764b156054838ffb5b02116fd78fbc38
Reviewed-on: https://chromium-review.googlesource.com/1068109
Commit-Queue: Steven Sawtelle <sawtelle@google.com>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563128}(cherry picked from commit a7333a897cef118f860fb4269feefb93465379d8)
Reviewed-on: https://chromium-review.googlesource.com/1082941
Cr-Commit-Position: refs/branch-heads/3440@{#190}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/chrome/app/generated_resources.grd
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/chrome/app/vector_icons/BUILD.gn
[add] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/chrome/app/vector_icons/picture_in_picture_alt.icon
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/chrome/browser/themes/theme_properties.h
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/chrome/browser/ui/cocoa/tabs/tab_view.mm
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/chrome/browser/ui/tabs/tab_utils.cc
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/chrome/browser/ui/tabs/tab_utils.h
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/chrome/browser/ui/views/tabs/tab_unittest.cc
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/0a419186d3e8fe4a6065f13ccf845e91cd643374/content/public/browser/web_contents.h

Once this task is completed, you can mark it as fixed. :)
Status: Fixed (was: Assigned)

Sign in to add a comment