New issue
Advanced search Search tips

Issue 842732 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

tab_switching.typical_25/multitab:misc:typical24 in performance_test_suite failing on chromium.perf/linux-perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 14 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of ashleymarie@google.com

tab_switching.typical_25/multitab:misc:typical24 in performance_test_suite failing on chromium.perf/linux-perf

Builders failed on: 
- linux-perf: 
  https://ci.chromium.org/buildbot/chromium.perf/linux-perf


 
Cc: vovoy@chromium.org

Comment 2 by vovoy@chromium.org, May 15 2018

Components: Speed>Tracing
error log in https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2Flinux-perf%2F64%2F%2B%2Frecipes%2Fsteps%2Fperformance_test_suite_on_NVIDIA_GPU_on_Linux%2F0%2Fstdout

Failure recorded: TypeError: Cannot read property 'browserHelper' of undefined
    at new tabsMetric (/tracing/metrics/tabs_metric.html:15:79)
    at runMetrics (/b/s/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:47:16)
    at metricMapFunction (/b/s/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:150:24)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:39:7)
    at eval (/b/s/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:24:10)
    at mapSingleTraceWithResult (/b/s/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/s/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:77:20)
    at eval (/b/s/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:90:15)
    at Object.loadHTMLFile (/b/s/w/ir/third_party/catapult/third_party/vinn/vinn/html_imports_loader.js:140:5)
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23e411cc8666eb095201383bb1872349d72cff60

commit 23e411cc8666eb095201383bb1872349d72cff60
Author: Annie Sullivan <sullivan@chromium.org>
Date: Tue May 22 18:27:01 2018

Disable failing tab_switching.typical_25 misc story on Linux.

Looks like this was forgotten in  bug 842732 . Perfbot sheriff disabling
to green up tree.

Bug:  842732 
Change-Id: I5affabbb0a1454dc16614efb8a70a8fd019f49e0
TBR: charliea@chromium.org
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/1069332
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560709}
[modify] https://crrev.com/23e411cc8666eb095201383bb1872349d72cff60/tools/perf/expectations.config

Owner: sadrul@chromium.org
Status: Started (was: Available)
I have put up https://chromium-review.googlesource.com/c/catapult/+/1083790 to fix this.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a7d578a2912159a22008768c34cfe02b875cf85a

commit a7d578a2912159a22008768c34cfe02b875cf85a
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Mon Jun 04 20:26:16 2018

tabs: Fix tabs metric.

Replace deprecated usage of |browserHelper| with |browserHelpers|, and
add a null-check for the chrome-helper.

BUG= chromium:842732 

Change-Id: Ie3baf5bf21378be6cc2d17d66ccf27c1fa7fd539
Reviewed-on: https://chromium-review.googlesource.com/1083790
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>

[modify] https://crrev.com/a7d578a2912159a22008768c34cfe02b875cf85a/tracing/tracing/metrics/tabs_metric.html

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99fa900045e32ad50d7ce5b7aa53ed37cfc6af5c

commit 99fa900045e32ad50d7ce5b7aa53ed37cfc6af5c
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Jun 04 23:53:32 2018

Roll src/third_party/catapult bf32270..a9d8c29 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/bf32270..a9d8c29


git log bf32270..a9d8c29 --date=short --no-merges --format='%ad %ae %s'
2018-06-04 sadrul@chromium.org tabs: Update the measurements.
2018-06-04 sadrul@chromium.org tabs: Fix tabs metric.


Created with:
  gclient setdep -r src/third_party/catapult@a9d8c29

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:849182 , chromium:842732 
TBR=sullivan@chromium.org

Change-Id: Ia0082975bc8c135e38b8183ca31a22596f2f78b0
Reviewed-on: https://chromium-review.googlesource.com/1086070
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564301}
[modify] https://crrev.com/99fa900045e32ad50d7ce5b7aa53ed37cfc6af5c/DEPS

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08ad1f41cabd6059c244fffce8c41b383bda817b

commit 08ad1f41cabd6059c244fffce8c41b383bda817b
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Wed Jun 06 00:32:23 2018

tab-switching: Re-enable tab_switching on linux.

Re-enable the tab-switching benchmark on linux after the tabs-metric fix
in crrev.com/c/1083790.

BUG= 842732 

Change-Id: Iac9ae2f83ccf6082bb3cf1e7223ccb89bf517f85
Reviewed-on: https://chromium-review.googlesource.com/1084056
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564735}
[modify] https://crrev.com/08ad1f41cabd6059c244fffce8c41b383bda817b/tools/perf/expectations.config

Status: Fixed (was: Started)

Sign in to add a comment