New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842729 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 842501
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

wasm/WasmZenGarden in wasm failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 14 2018

Issue description

DevtoolsTargetCrashException: Devtools target crashed

Looks like chrome is crashing pretty consistently for WasmZenGarden
I'll kick off a bisect from r557744 to r557806
that bisect range should actually be r557805 to r557859
Project Member

Comment 4 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a185745cb40a356a37535438f9d19e37136b225e

commit a185745cb40a356a37535438f9d19e37136b225e
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Mon May 14 19:02:09 2018

Disabling warmzengarden

Bug:  842729 
Change-Id: I66e634c272f445ea2eb482722251a68fca0579bb

TBR=eyaich@

Change-Id: I66e634c272f445ea2eb482722251a68fca0579bb
Reviewed-on: https://chromium-review.googlesource.com/1057832
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558400}
[modify] https://crrev.com/a185745cb40a356a37535438f9d19e37136b225e/tools/perf/expectations.config

Components: Blink>JavaScript
Status: Untriaged (was: Available)
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, May 18 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14b23130240000

__init__() got an unexpected keyword argument 'scope'
Cc: titzer@chromium.org ashleymarie@chromium.org ahaas@chromium.org
https://chromium.googlesource.com/v8/v8/+/a83277498ca7f2719138226fbbe8660b5f818571 is Wasm related in the range.

@Ashleymarie: What's up with Pinpoint?

@Wasm folks: Clemens (the reviewer) is OOO, can somebody of you please take a look?
Cc: bbudge@chromium.org
 Issue 842262  has been merged into this issue.
Cc: dtu@chromium.org
@dtu: thoughts about pinpoint failure?
Cc: aseemgarg@chromium.org

Comment 11 by dtu@chromium.org, May 25 2018

There was a bad deployment to Pinpoint at that time. I'll re-run now (on the narrower range r557858-r557861)
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, May 26 2018

Cc: kanghua...@intel.com
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12cc8d32240000

[turbofan][x64] Reduce compare-zero followed by flags-setting binop by kanghua.yu@intel.com
https://chromium.googlesource.com/v8/v8/+/423343635042c2d9b05a850ebc1d2fc3fc9cc4f5

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 14 by ahaas@chromium.org, May 28 2018

Mergedinto: 842501
Status: Duplicate (was: Assigned)
Ah, we already fixed the issue introduced by "[turbofan][x64] Reduce compare-zero followed by flags-setting binop".
Project Member

Comment 15 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1ad79bef331ee38990a85f4a0109704dd785557

commit d1ad79bef331ee38990a85f4a0109704dd785557
Author: Andreas Haas <ahaas@chromium.org>
Date: Tue May 29 14:23:25 2018

Enable wasmzengarden

The problem why the benchmark got disabled has been fixed, see
 https://crbug.com/842501 . We should re-enable the tests again.

R=eyaich@chromium.org

Bug:  chromium:842729 
Change-Id: Ieb5acf000a5feddba2098b384c0be3607b433c31
Reviewed-on: https://chromium-review.googlesource.com/1075519
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562414}
[modify] https://crrev.com/d1ad79bef331ee38990a85f4a0109704dd785557/tools/perf/expectations.config

Sign in to add a comment