Not able to see ids from all pak entries |
||
Issue descriptionRun: tools/binary_size/diagnose_bloat.py --cloud 770b43709b7a1d31faf5a456423e84c727192635 See: Section Legend: t=.text, r=.rodata, R=.data.rel.ro, d=.data, b=.bss, x=.dex, m=.dex.method, p=.pak.translations, P=.pak.nontranslated, o=.other Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path ------------------------------------------------------------ ~ 0) -2292 (-6.8%) o@0x0 -2292 (0->0) {no path} Overhead: ELF file ~ 1) -4130 (-12.3%) o@0x0 -1838 (0->0) {no path} Overhead: APK file + 2) -2646 (-7.9%) p@0x4ead 1484 (0->1484) content/browser/accessibility/browser_accessibility_android.cc + 3) -1374 (-4.1%) p@0x4eab 1272 (0->1272) content/browser/accessibility/browser_accessibility_android.cc + 4) -102 (-0.3%) p@0x4ebe 1272 (0->1272) content/browser/accessibility/browser_accessibility_android.cc + 5) 1117 (3.3%) p@0x4ecc 1219 (0->1219) content/browser/accessibility/browser_accessibility_android.cc + 6) 2336 (7.0%) p@0x4ed1 1219 (0->1219) content/browser/accessibility/browser_accessibility_android.cc + 7) 3449 (10.3%) p@0x4ea7 1113 (0->1113) content/browser/accessibility/browser_accessibility_android.cc + 8) 4562 (13.6%) p@0x4ed2 1113 (0->1113) content/browser/accessibility/browser_accessibility_android.cc + 9) 5675 (17.0%) p@0x4ed3 1113 (0->1113) content/browser/accessibility/browser_accessibility_android.cc + 10) 6735 (20.1%) p@0x4ec1 1060 (0->1060) content/browser/accessibility/browser_accessibility_android.cc + 11) 7689 (23.0%) p@0x4eac 954 (0->954) content/browser/accessibility/browser_accessibility_android.cc + 12) 8643 (25.8%) p@0x4ec0 954 (0->954) content/browser/accessibility/browser_accessibility_android.cc + 13) 9491 (28.4%) p@0x4eb0 848 (0->848) content/browser/accessibility/browser_accessibility_android.cc + 14) 10339 (30.9%) p@0x4eb4 848 (0->848) content/browser/accessibility/browser_accessibility_android.cc + 15) 11187 (33.4%) p@0x4ec3 848 (0->848) content/browser/accessibility/browser_accessibility_android.cc + 16) 11982 (35.8%) p@0x4ea8 795 (0->795) content/browser/accessibility/browser_accessibility_android.cc + 17) 12777 (38.2%) p@0x4eaa 795 (0->795) content/browser/accessibility/browser_accessibility_android.cc + 18) 13572 (40.5%) p@0x4ec4 795 (0->795) content/browser/accessibility/browser_accessibility_android.cc + 19) 14367 (42.9%) p@0x4ec8 795 (0->795) content/browser/accessibility/browser_accessibility_android.cc + 20) 15109 (45.1%) p@0x4ea6 742 (0->742) content/browser/accessibility/browser_accessibility_android.cc + 21) 15851 (47.4%) p@0x4ea9 742 (0->742) content/browser/accessibility/browser_accessibility_android.cc + 22) 16593 (49.6%) p@0x4eaf 742 (0->742) content/browser/accessibility/browser_accessibility_android.cc + 23) 17335 (51.8%) p@0x4eb6 742 (0->742) content/browser/accessibility/browser_accessibility_android.cc Expected: Actual IDS strings.
,
May 24 2018
A bigger problem than I realized.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05041ffefe531fe3db04efd390d26c8259813fcf commit 05041ffefe531fe3db04efd390d26c8259813fcf Author: Peter Wen <wnwen@chromium.org> Date: Thu May 24 20:51:49 2018 Supersize: Fix pak name processing Pak symbols were not getting their full name propagated to name and template_name, making it harder to see their names in the diffs. Bug: 842728 Change-Id: Id98edbc246239f053ab48d398adf3a058a022514 Reviewed-on: https://chromium-review.googlesource.com/1072496 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#561621} [modify] https://crrev.com/05041ffefe531fe3db04efd390d26c8259813fcf/tools/binary_size/libsupersize/archive.py
,
May 24 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by wnwen@chromium.org
, May 24 2018