"Preserve" color space conversion for createImageBitmap? |
||
Issue descriptionAccording to the discussion with junov@ and fserb@, it seems that we should add a "preserve" color space conversion mode to ImageBitmap. In this mode, the image bitmap will "preserve" the color space / ICC profile of the source, whatever it is.
,
Sep 13
Furthermore, it should avoid precision loss due to internal storage format. So if the image is P3 8888, we can go with 8888 image bitmap, but if the source is 16 bit PNG, we should go for a f16 image bitmap.
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bdeee6598f0a6dd657efb6f589f465b354ce573 commit 1bdeee6598f0a6dd657efb6f589f465b354ce573 Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Wed Sep 19 22:01:26 2018 Add "preserve" color space conversion option to ImageBitmap This CL: - adds "preserve" color space conversion option to ImageBitmap. - replaces sRGB with color spin color space as the source color space in ImageBitmap unit tests. - removes SkColorSpaceXform usage from ImageBitmap unit tests. Bug:842688, 774520 TBR=fserb@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I62df4c8bd0cd69b0da36dee4dd2f62ed1714d884 Reviewed-on: https://chromium-review.googlesource.com/1234017 Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#592565} [modify] https://crrev.com/1bdeee6598f0a6dd657efb6f589f465b354ce573/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc [modify] https://crrev.com/1bdeee6598f0a6dd657efb6f589f465b354ce573/third_party/blink/renderer/core/imagebitmap/image_bitmap.h [modify] https://crrev.com/1bdeee6598f0a6dd657efb6f589f465b354ce573/third_party/blink/renderer/core/imagebitmap/image_bitmap_options.idl [modify] https://crrev.com/1bdeee6598f0a6dd657efb6f589f465b354ce573/third_party/blink/renderer/core/imagebitmap/image_bitmap_test.cc [modify] https://crrev.com/1bdeee6598f0a6dd657efb6f589f465b354ce573/third_party/blink/renderer/platform/graphics/color_correction_test_utils.cc [modify] https://crrev.com/1bdeee6598f0a6dd657efb6f589f465b354ce573/third_party/blink/renderer/platform/graphics/color_correction_test_utils.h [modify] https://crrev.com/1bdeee6598f0a6dd657efb6f589f465b354ce573/third_party/blink/renderer/platform/graphics/static_bitmap_image.cc [modify] https://crrev.com/1bdeee6598f0a6dd657efb6f589f465b354ce573/third_party/blink/renderer/platform/graphics/static_bitmap_image.h
,
Sep 20
|
||
►
Sign in to add a comment |
||
Comment 1 by junov@chromium.org
, Jul 25