New issue
Advanced search Search tips

Issue 842665 link

Starred by 4 users
Status: Fixed
Owner:
f...@opera.com
Closed: Sep 17
Cc:
ericwilligers@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Inconsistent computed style serialization for URLs.

Project Member Reported by emilio@chromium.org, May 14 2018 
Chrome Version       : Trunk
OS Version: 
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
    Firefox: OK

What steps will reproduce the problem?
1. Open attached test-case.

What is the expected result?
Either both URLs are absolute, or both are relative (I think both should be absolute).

What happens instead of that?
They're inconsistent.
test.html
281 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eb6b522cc683b4f55ea2348239df3533057e94b

commit 0eb6b522cc683b4f55ea2348239df3533057e94b
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Sep 17 09:42:26 2018

Change serialization for SVG resource url(...)'s

For non-local URLs, serialize the absolute form.

Reduce the AtomicString <-> String impedance while at it.

Bug:  842665 
Change-Id: Ibc7804eeb6436d32202915e20e612b7bb5cf6b94
Reviewed-on: https://chromium-review.googlesource.com/1213175
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#591627}
[delete] https://crrev.com/e54834cb98505441c722b71b098cba10194970ef/third_party/WebKit/LayoutTests/fast/masking/parsing-clip-path-iri-expected.txt
[modify] https://crrev.com/0eb6b522cc683b4f55ea2348239df3533057e94b/third_party/WebKit/LayoutTests/fast/masking/parsing-clip-path-iri.html
[add] https://crrev.com/0eb6b522cc683b4f55ea2348239df3533057e94b/third_party/WebKit/LayoutTests/svg/css/url-serialization-resource-references.html
[modify] https://crrev.com/0eb6b522cc683b4f55ea2348239df3533057e94b/third_party/blink/renderer/core/css/css_uri_value.h
[modify] https://crrev.com/0eb6b522cc683b4f55ea2348239df3533057e94b/third_party/blink/renderer/core/css/properties/computed_style_utils.cc
[modify] https://crrev.com/0eb6b522cc683b4f55ea2348239df3533057e94b/third_party/blink/renderer/core/css/properties/longhands/clip_path_custom.cc
[modify] https://crrev.com/0eb6b522cc683b4f55ea2348239df3533057e94b/third_party/blink/renderer/core/css/resolver/filter_operation_resolver.cc
[modify] https://crrev.com/0eb6b522cc683b4f55ea2348239df3533057e94b/third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
[modify] https://crrev.com/0eb6b522cc683b4f55ea2348239df3533057e94b/third_party/blink/renderer/core/style/filter_operation.cc
[modify] https://crrev.com/0eb6b522cc683b4f55ea2348239df3533057e94b/third_party/blink/renderer/core/style/filter_operation.h
[modify] https://crrev.com/0eb6b522cc683b4f55ea2348239df3533057e94b/third_party/blink/renderer/core/style/reference_clip_path_operation.h
[modify] https://crrev.com/0eb6b522cc683b4f55ea2348239df3533057e94b/third_party/blink/renderer/core/style/svg_computed_style_defs.cc
[modify] https://crrev.com/0eb6b522cc683b4f55ea2348239df3533057e94b/third_party/blink/renderer/core/style/svg_computed_style_defs.h

Comment 2 by f...@opera.com, Sep 17

Owner: f...@opera.com
Status: Fixed (was: Available)
►

Sign in to add a comment