New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842664 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 760181



Sign in to add a comment

Flaky IndependentOTRProfileManagerTest.DeleteImmediatelyWhenBrowsersAlreadyClosed on Mac Viz

Project Member Reported by jonr...@chromium.org, May 14 2018

Issue description

OS: Mac
Test suite: browser_tests
Test: IndependentOTRProfileManagerTest.DeleteImmediatelyWhenBrowsersAlreadyClosed

Example failure build: https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/2841

Failure:
../../chrome/browser/media/router/presentation/independent_otr_profile_manager_browsertest.cc:205: Failure
Value of: base::ContainsValue(*BrowserList::GetInstance(), otr_browser2)
  Actual: true
Expected: false
Stack trace:
0   browser_tests                       0x000000010648245b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   browser_tests                       0x0000000106481e19 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   browser_tests                       0x000000010520b5fd IndependentOTRProfileManagerTest_DeleteImmediatelyWhenBrowsersAlreadyClosed_Test::RunTestOnMainThread() + 1357
3   browser_tests                       0x0000000108818643 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 515
4   browser_tests                       0x000000010833d819 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4233
5   browser_tests                       0x000000010833c68e ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
6   browser_tests                       0x0000000106f2d303 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
7   browser_tests                       0x00000001072efb57 content::StartupTaskRunner::RunAllTasksNow() + 39
8   browser_tests                       0x0000000106f2bedd content::BrowserMainLoop::CreateStartupTasks() + 813
9   browser_tests                       0x0000000106f2f4c2 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 98
10  browser_tests                       0x0000000106f29f8c content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 204
11  browser_tests                       0x0000000108180aa8 content::ContentMainRunnerImpl::Run() + 616
12  browser_tests                       0x0000000109d49434 service_manager::Main(service_manager::MainParams const&) + 2708
13  browser_tests                       0x000000010817faa4 content::ContentMain(content::ContentMainParams const&) + 68
14  browser_tests                       0x000000010881825e content::BrowserTestBase::SetUp() + 2574
15  browser_tests                       0x00000001082c4348 InProcessBrowserTest::SetUp() + 536

There was the odd non-viz flake a while back on flakiness dashboard. However those builds were too old and logs were gone.

Seems to fail with viz >10% of the time.

From the stack trace it looks like a missing browser. So it may not be viz related, but the timing changes we cause could be exposing the flake. Could you take a look and help triage?
 
Status: Assigned (was: Untriaged)
I don't have any ideas offhand, and browser initialization isn't something that I'm very proficient with.
Cc: ccameron@chromium.org
Owner: btolsch@chromium.org
Hey btolsch@, I see that you've added the test we're seeing fail. Could you help provide insight into the error that we are seeing?

There seems to be a race where the test fails to detect a browser.

I see this test flaking out when running with the argument: --enable-surface-synchronization

Status: Started (was: Assigned)
This looks like the same cause that I fixed in other related tests.  Somehow it didn't occur to me to fix these too.  https://chromium-review.googlesource.com/c/chromium/src/+/1074330 is out for this.
Project Member

Comment 5 by bugdroid1@chromium.org, May 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ef116c6f2ef244398a06814c532e003e15abfb4

commit 3ef116c6f2ef244398a06814c532e003e15abfb4
Author: btolsch <btolsch@chromium.org>
Date: Sat May 26 19:28:27 2018

Fix remaining IndependentOTRProfileManagerTest flakes

A previous change (https://chromium-review.googlesource.com/1034279)
fixed some RunUntilIdle-based flakes by explicitly waiting for
OnBrowserRemoved.  For some strange reason, the other tests in the file
weren't considered.  This change applies the same fix to the remaining
tests.

Bug:  842664 
Change-Id: I6abac09b4a3a0940e69f83005a39adc132f68fa7
Reviewed-on: https://chromium-review.googlesource.com/1074330
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562128}
[modify] https://crrev.com/3ef116c6f2ef244398a06814c532e003e15abfb4/chrome/browser/media/router/presentation/independent_otr_profile_manager_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment