Issue metadata
Sign in to add a comment
|
Navigating can stop UI elements from rendering. |
||||||||||||||||||||||||||||
Issue descriptionI was able to repro by doing this 1. Enter VR browsing 2. Navigate forward and backward (by typing in the omnibox and clicking the back button). Eventually, I got into a state where the content, the laser, the reticle and the floor grid weren't rendering. Some of the UI did render, though (eg, the controller). Interestingly, when I hadn't downloaded the background component, when I got into this state I drew only a grey skybox (no gradient) and there were clearly visible seams between the faces. This appears unrelated to the tree walk optimizations, but I haven't had a chance to bisect.
,
May 14 2018
I haven't been able to reproduce this. I'll keep trying while testing other work.
,
May 17 2018
Stopping work until someone can repro this again.
,
May 28 2018
This issue was reported on the 14th, and clipping support landed May 11. There was an issue with clip region hiding the platform UI texture that needed fixing. The laser is drawn using its own fragment shader, but is a BaseQuadRenderer and BaseRenderer under the hood, which were affected by the clipping CL. It does't look like the laser could have been affected, but on closer inspection, BaseRenderer calls into the program to get the location of u_ClipRect, something not present in all elements (like the laser). This is probably benign, but I wonder if any code should be DCHECKing on a valid clip rect uniform. The timing relative to the clipping change just seems too suspect. Aldo, can you see a direct link between the clipping issue and what Ian saw?
,
May 31 2018
I cannot see the relationship. Querying a uniform that is not found in the shader is not a problem, even if you try to use the handle. Also, the bugfix was specific to external textures.
,
May 31 2018
Ian, I assume there's no chance this was a local change, but I wasn't able to repro, and there's been no other sightings. Was this readily reproducible for you? I think we should close this off and reopen if it's seen again. Assigning to you to disagree or close.
,
Jun 1 2018
Yeah, if no one can repro, I think we should close it out, too. |
|||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||
Comment 1 by cjgrant@chromium.org
, May 14 2018Status: Started (was: Available)