Video orientation from iOS client is incorrect in Chrome 67
Reported by
yu...@appear.in,
May 3 2018
|
||||||||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Join AppRTC room from Chrome 67 (beta) 2. Join the same room from AppRTC client on iOS What is the expected result? Video received from iOS client in Chrome is rotated correctly according to iOS device orientation. What do you see instead? Video received from iOS client in Chrome is rotated sideways when iOS client is in portrait. Orientation doesn't change at all when iOS device is rotated. What version of the product are you using? On what operating system? Desktop: macOS 10.13.4 (17E202) Chrome Version 67.0.3396.30 (Official Build) beta (64-bit) iOS: 11.3.1 (15E302) AppRTC build from latest commit in master: a1f566b28a69512037e36f5194329d9ada46be01 Please provide any additional information below. WebRTC internals dump attached. Works as expected in Chrome 66.
,
May 3 2018
also reproducible with the appear.in and talky.io apps ios apps. Makes it looks like the other person useds Konrads Kalasklister ;-)
,
May 3 2018
,
May 4 2018
Google Chrome 67.0.3371.0 (which used to be unstable at some point) still shows the correct behaviour.
,
May 4 2018
bad: 67.0.3396.18 bad: 67.0.3386.1 good: 67.0.3381.0 Looking at https://chromium.googlesource.com/chromium/src/+log/67.0.3381.0..67.0.3386.0?pretty=fuller&n=10000 and taking the autoroller commit hashes I get https://webrtc.googlesource.com/src.git/+log/dc4737bbdacc..0ffe03d2ef6f I don't see anything suspicious offhand.
,
May 4 2018
Does this repro when receiving video from Android?
,
May 4 2018
Setting you as owner Sami since you seem to be on top of this right now.
,
May 4 2018
,
May 6 2018
not from Chrome 66 on android from what I can see. Chrome 68.0.3418.2 seems to fix this so there are now two bisect windows :-)
,
May 7 2018
Does the version of AppRTCMobile on iOS matter? If not, this is probably not mobile bug?
,
May 7 2018
since it changes with Chrome version i'd say its a problem on that side. Throw it over to gui-"master of bisect"-do? :-)
,
May 7 2018
Also reproducible with AppRTCMobile on iOS built from older stable branch 64. I agree that looks like the problem is on Chrome side.
,
May 7 2018
Unassigning for a new triage. This should probably be assigned to someone working with WebRTC on Mac.
,
May 7 2018
,
May 7 2018
,
May 14 2018
kthelgason@, could you find a suitable owner for this?
,
May 14 2018
This is not a bug in WebRTC iOS, more likely on the chrome side. Guido, can you help this issue find its rightful onwer?
,
May 14 2018
,
May 14 2018
,
May 14 2018
,
May 14 2018
apparently fixed between 67.0.3396.30 (bad) and 67.0.3396.40 which reduces priority to "why did this break?"
,
May 14 2018
,
May 14 2018
Given comment #21 that it has been already been fixed and the difficulty of finding anyone willing to own it, I'll close this bug. Please reopen if needed.
,
May 14 2018
https://chromium-review.googlesource.com/c/chromium/src/+/1036605 probably fixed it. GpuMemoryBufferVideoFramePool wasn't preserving rotation information. |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by fi...@appear.in
, May 3 2018