New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 842644 link

Starred by 1 user
Status: Fixed
Owner:
█ vollick@chromium.org
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Nested visibility animations do not start simultaneously

Project Member Reported by vollick@chromium.org, May 14 2018 
When updating bindings, we recur if a subtree will be visible.

However, when updating animations, we recur when an element was visible during the frame. This means that if a parent and child both animate to visible, since the parent's animation starts at opacity 0, the child won't get ticked until the next frame. This can cause small delays to animation start times.
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2f2e6458eb9c816f07b12a632ef81e8d3bb44a0

commit e2f2e6458eb9c816f07b12a632ef81e8d3bb44a0
Author: Ian Vollick <vollick@chromium.org>
Date: Mon May 14 17:09:48 2018

[vr] Permit nested visibility animations to start simultaneously

Like bindings, we now recur updating anims if we are or will be seen.

Also removes flag to disable truncated treewalks.

Bug:  842644 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I26ac8a140c86b3ef223d00677a710709ca207cea
Reviewed-on: https://chromium-review.googlesource.com/1057347
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558346}
[modify] https://crrev.com/e2f2e6458eb9c816f07b12a632ef81e8d3bb44a0/chrome/browser/vr/elements/transient_element_unittest.cc
[modify] https://crrev.com/e2f2e6458eb9c816f07b12a632ef81e8d3bb44a0/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/e2f2e6458eb9c816f07b12a632ef81e8d3bb44a0/chrome/browser/vr/elements/ui_element_unittest.cc

Comment 2 by vollick@chromium.org, May 14 2018

Status: Fixed (was: Started)

Comment 3 by dougman@chromium.org, May 15 2018

Labels: M-68 Test-Complete
►

Sign in to add a comment