Issue metadata
Sign in to add a comment
|
Regression : Focus lost is seen on 'chrome://settings/signOut' overlay.
Reported by
pranjali...@etouch.net,
May 14 2018
|
||||||||||||||||||||||
Issue descriptionChrome version : 68.0.3430.0 (Official Build) 86b7f367e2f749a0e39f2ca86c7644b6aec7a432-refs/branch-heads/3430@{#1} (32/64-bit) OS : Windows(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.5) OS and Linux(14.04 LTS) OS. Precondition: Sign in to chrome with valid credentials. Steps to reproduce: 1. Launch chrome and navigate to 'chrome://settings/signOut'. 2. Press tab key until focus reaches to 'show profile stats' toggle button and press enter key 2-3 times. 3. Observe Actual Result: Focus lost is seen on 'show profile stats' toggle button on pressing enter key. Expected Result: Focus should stay on 'show profile stats' toggle button on pressing enter key. This is a regression issue broken in ‘M-61’ and will soon update other bisect info. Good build: 61.0.3150.0 (Revision : 484425) Bad build: 61.0.3152.0 (Revision : 485105) You are probably looking for a change made after 484994 (known good), but no later than 484995 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/75bf68312a3998a396bbc0a44f88e0b62acb17ec..4b488983778a6d9d6c60c2620ddf8e3ca99e84cc Suspect: https://chromium.googlesource.com/chromium/src/+/4b488983778a6d9d6c60c2620ddf8e3ca99e84cc @dschuyler: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank you.
,
May 22 2018
,
May 22 2018
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63200668840cd428988b39dae9af533c688d1c74 commit 63200668840cd428988b39dae9af533c688d1c74 Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed May 30 00:13:51 2018 WebUI: cr-expand-button, hold ripple for keyboard only Bug: 842640 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0fdff364e8404a5de21a0160a4dc765f6571b5de Reviewed-on: https://chromium-review.googlesource.com/1069718 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#562667} [modify] https://crrev.com/63200668840cd428988b39dae9af533c688d1c74/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html [modify] https://crrev.com/63200668840cd428988b39dae9af533c688d1c74/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.js
,
May 30 2018
Focus state should remain visible after initial ripple when using keyboard (when using space and enter). No additional ripples after subsequent keypresses. For touches and mouse clicks, the expand button should only ripple.
,
May 30 2018
Update : Rechecked the above issue on Windows(7,8,8.1,10),Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) OS with latest Canary build #69.0.3445.0 and the issue is Fixed.Kindly refer the attached screen cast for reference. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dschuyler@chromium.org
, May 22 2018