Regression : Tab focus is invisible on "Enable casting to cloud-based.." checkbox, in Cast dialog.
Reported by
avsha...@etouch.net,
May 14 2018
|
||||
Issue descriptionChrome Version : 68.0.3430.0 (Official Build) 86b7f367e2f749a0e39f2ca86c7644b6aec7a432-refs/branch-heads/3430@{#1} 32/64-bit OS : Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, click on 'Avatar' icon and sign in to chrome with valid credentials. 2. Open NTP, right click on the page and open 'Cast' dialog. 3. Hit Tab key twice to bring focus on "Enable casting to cloud-based.." checkbox and observe the focus. Actual Result : Tab focus is invisible on "Enable casting to cloud-based.." checkbox, in Cast dialog. Expected Result : In Cast dialog, Tab focus should be clearly visible on "Enable casting to cloud-based.." checkbox. This is a regression issue, broken in M-68 and providing the bisect using Per-Revision script: Good Build : 68.0.3424.0 (Revision : 556638) Bad Build : 68.0.3425.0 (Revision : 557062) Change Log URL : https://chromium.googlesource.com/chromium/src/+log/7de47372cbcfae05df70938a248b04ce62c94379..5ad171e960ab24624597dfebe08fbee78f153317 Suspect : https://chromium.googlesource.com/chromium/src/+/5ad171e960ab24624597dfebe08fbee78f153317 @Scott : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
May 14 2018
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f715bd6e03f64cf8ab409fa84b495650c26e5eda commit f715bd6e03f64cf8ab409fa84b495650c26e5eda Author: Scott Chen <scottchen@chromium.org> Date: Tue May 15 00:52:22 2018 WebUI: make media-router checkbox focus more obvious. Since switching to cr-checkbox, the focus of the checkbox within media-router becomes very hard to see. This CL updates the focus style to be more visible. Also simplifies the learn-more link HTML to make it clickable within cr-checkbox. (I looked at the original CL that added the span within the anchor tag, and there doesn't seem to be a reason the nested structure is necessary https://codereview.chromium.org/1606303005). Bug: 842631 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If628e716284ca9477559e84a689db55790ee9180 Reviewed-on: https://chromium-review.googlesource.com/1058331 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558558} [modify] https://crrev.com/f715bd6e03f64cf8ab409fa84b495650c26e5eda/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css [modify] https://crrev.com/f715bd6e03f64cf8ab409fa84b495650c26e5eda/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html [modify] https://crrev.com/f715bd6e03f64cf8ab409fa84b495650c26e5eda/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html
,
May 15 2018
,
May 16 2018
Update : Retested above issue in latest Canary build #68.0.3432.0 on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5) & Linux(14.04 LTS) OS and the issue is fixed. Tab focus is seen as intended on checkbox in Cast dialog. Kindly review an attached screen-cast. Thank you..! |
||||
►
Sign in to add a comment |
||||
Comment 1 by mfo...@chromium.org
, May 14 2018