New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 842622 link

Starred by 3 users
Status: Started
Owner:
█ yangsharon@google.com
Last visit > 30 days ago
Cc:
█ awdf@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Adding notifications UKM

Project Member Reported by yangsharon@google.com, May 14 2018 
All our existing client-side web notification metrics are dominated by big sites, so we don't have an accurate picture of 
-how most web developers are using our APIs, or 
-how users interact with notifications, independent of which sites they originate from.
 
We would like to know this in order to:
have greater insight on spikes/dips in our metrics (eg did we break something, or did BigSite.com just change how they use notifications?),
inform future development of the APIs (e.g. knowing how many sites we'd break if we want to deprecate a feature), and figure out what good & bad user-signals are common themes across many sites - so we can give better advice to sites on do's & don't's when sending notifications.

Additionally, we are currently unable to correlate our metrics, e.g. we know what % of notifications are clicked on, and what % of notifications have images, but we have no way to know whether notifications with images get clicked on more frequently than notifications without images. This type of in-depth insight will also help with all the bullet points above.
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d817469566a20179ecaa1b563f79ad895fa6d84e

commit d817469566a20179ecaa1b563f79ad895fa6d84e
Author: Sharon Yang <yangsharon@google.com>
Date: Fri May 18 16:49:05 2018

Add more proto fields for notification UKM collection.

Added more proto fields to facilitate future collecting of UKM. We are adding
them as proto fields so the information we want to collect can be written to the
database and we can avoid storing the information in memory unnecessarily.

This is part of a series of CLs to add UKM for notifications.

Existing unit tests and related methods were updated with the new fields.

Bug: 842622
Change-Id: Ic2d04b8b9bfdc724f4fa7bc5d3c549b243357077
Reviewed-on: https://chromium-review.googlesource.com/1059287
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Sharon Yang <yangsharon@google.com>
Cr-Commit-Position: refs/heads/master@{#559925}
[modify] https://crrev.com/d817469566a20179ecaa1b563f79ad895fa6d84e/content/browser/notifications/notification_database_data.proto
[modify] https://crrev.com/d817469566a20179ecaa1b563f79ad895fa6d84e/content/browser/notifications/notification_database_data_conversions.cc
[modify] https://crrev.com/d817469566a20179ecaa1b563f79ad895fa6d84e/content/browser/notifications/notification_database_data_unittest.cc
[modify] https://crrev.com/d817469566a20179ecaa1b563f79ad895fa6d84e/content/public/browser/notification_database_data.h

Comment 2 by yitingc@chromium.org, May 23 2018 

UKM collection LGTM by privacy.
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d96cd4b5ff1d767d9c1cae85860a6855a2896dd8

commit d96cd4b5ff1d767d9c1cae85860a6855a2896dd8
Author: Sharon Yang <yangsharon@google.com>
Date: Thu May 31 11:43:43 2018

Update NotificationDatabaseData fields when clicked.

This updates fields in NotificationDatabaseData when the notification is
clicked. This information will be used for UKM logging.

Bug: 842622
Change-Id: I2c677dd260db53dbc761c16bd8288ba915631e61
Reviewed-on: https://chromium-review.googlesource.com/1070162
Commit-Queue: Sharon Yang <yangsharon@google.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563194}
[modify] https://crrev.com/d96cd4b5ff1d767d9c1cae85860a6855a2896dd8/content/browser/notifications/blink_notification_service_impl_unittest.cc
[modify] https://crrev.com/d96cd4b5ff1d767d9c1cae85860a6855a2896dd8/content/browser/notifications/notification_database.cc
[modify] https://crrev.com/d96cd4b5ff1d767d9c1cae85860a6855a2896dd8/content/browser/notifications/notification_database.h
[modify] https://crrev.com/d96cd4b5ff1d767d9c1cae85860a6855a2896dd8/content/browser/notifications/notification_database_unittest.cc
[modify] https://crrev.com/d96cd4b5ff1d767d9c1cae85860a6855a2896dd8/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/d96cd4b5ff1d767d9c1cae85860a6855a2896dd8/content/browser/notifications/platform_notification_context_impl.cc
[modify] https://crrev.com/d96cd4b5ff1d767d9c1cae85860a6855a2896dd8/content/browser/notifications/platform_notification_context_impl.h
[modify] https://crrev.com/d96cd4b5ff1d767d9c1cae85860a6855a2896dd8/content/browser/notifications/platform_notification_context_unittest.cc
[modify] https://crrev.com/d96cd4b5ff1d767d9c1cae85860a6855a2896dd8/content/public/browser/platform_notification_context.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea520d8c3291633be90f36fb9a75fa0e42761f2e

commit ea520d8c3291633be90f36fb9a75fa0e42761f2e
Author: Sharon Yang <yangsharon@google.com>
Date: Wed Jul 25 20:46:53 2018

Add notifications to UKM.xml.

Added notifications and related metrics to ukm.xml and included logging
of some metrics that have been recorded to the database already,
including the number of clicks, number of action button clicks and the
ClosedReason for the notification.

UKM Collection Review:
https://docs.google.com/document/d/1oUfHs_t5gEOhMYvjoC2so2Ie_Pt51m12XIgEpbzfU1k/edit?usp=sharing

Bug: 842622
Change-Id: Iabe9e3065e5d0c5c677545873d2e1ea630aea45d
Reviewed-on: https://chromium-review.googlesource.com/1071649
Commit-Queue: Sharon Yang <yangsharon@google.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Robert Kaplow (OOO until 0730) <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578048}
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/content/browser/notifications/notification_database.cc
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/content/browser/notifications/notification_database.h
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/content/browser/notifications/notification_database_unittest.cc
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/content/browser/notifications/platform_notification_context_impl.cc
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/content/browser/notifications/platform_notification_context_impl.h
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/content/public/browser/platform_notification_service.h
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/content/test/mock_platform_notification_service.cc
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/content/test/mock_platform_notification_service.h
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/services/metrics/public/cpp/ukm_recorder.h
[modify] https://crrev.com/ea520d8c3291633be90f36fb9a75fa0e42761f2e/tools/metrics/ukm/ukm.xml
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0ad806d8696291f314f87cd6f6c3b47e04d2941

commit d0ad806d8696291f314f87cd6f6c3b47e04d2941
Author: Sharon Yang <yangsharon@google.com>
Date: Wed Aug 01 10:31:49 2018

Add remaining notification fields to logged UKM

This change now logs the rest of the notification UKM fields that were
previously not logged. How they are logged is unchanged.

Bug: 842622
Change-Id: Id4deab3a09dc6ff19ecdde076460b3927358b622
Reviewed-on: https://chromium-review.googlesource.com/1151116
Commit-Queue: Sharon Yang <yangsharon@google.com>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579750}
[modify] https://crrev.com/d0ad806d8696291f314f87cd6f6c3b47e04d2941/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/d0ad806d8696291f314f87cd6f6c3b47e04d2941/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/d0ad806d8696291f314f87cd6f6c3b47e04d2941/content/browser/notifications/notification_database_data_conversions.cc

Comment 7 by awdf@chromium.org, Aug 2 

 Issue 789505  has been merged into this issue.

Comment 8 by jmukthavaram@chromium.org, Nov 20

Labels: Hotlist-DesktopUIChecked
**UI Mass Triage **

Please close if there is no pending work.
Thanks.!
►

Sign in to add a comment