Regression : Unable to check/uncheck checkbox after pressing 'Enter' key present on 'Number Pad' in chrome://settings/languages.
Reported by
rp...@etouch.net,
May 14 2018
|
|||
Issue descriptionVersion: 68.0.3430.0 (Official Build) Revision 86b7f367e2f749a0e39f2ca86c7644b6aec7a432-refs/branch-heads/3430@{#1}(32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1) What steps will reproduce the problem? 1. Launch chrome,navigate to chrome://settings/languages 2. Now click to expand 'Languages' and then click on 'Add Languages' to open overlay 3. Now click on any of check boxes and press 'Enter' key present on 'Number Pad' and observe Actual: Unable to check/uncheck checkbox after pressing 'Enter' key present on 'Number Pad' Expected: Should be able to check/uncheck checkbox after pressing 'Enter' key present on 'Number Pad' This is regression issue, broken in ‘M 68’ and below is the bisect info : Good build: 68.0.3424.0 (Revision: 556638). Bad build: 68.0.3425.0 (Revision: 557062). You are probably looking for a change made after 556947 (known good), but no later than 556948 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/7de47372cbcfae05df70938a248b04ce62c94379..5ad171e960ab24624597dfebe08fbee78f153317 Suspect : https://chromium.googlesource.com/chromium/src/+/5ad171e960ab24624597dfebe08fbee78f153317 From the CL above, assigning the issue to the concern owner @scottchen- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : Above issue is reproduced only after pressing 'Enter' key present on 'Number Pad' of keyboard and not for 'Enter' key present in normal keyboard section Thanks!
,
May 14 2018
Verified also true with the new cr-toggle.
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/578602575ab3499947834e52b6bb2c800ab5f2be commit 578602575ab3499947834e52b6bb2c800ab5f2be Author: Scott Chen <scottchen@chromium.org> Date: Tue May 15 01:36:58 2018 WebUI: use .key instead of .code for cr-toggle/checkbox This CL makes the Enter key on the number-pad work like the normal enter key. Bug: 842608 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I18d5712e2b6b7d316f19f7b43951a9266b411c7e Reviewed-on: https://chromium-review.googlesource.com/1058114 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#558575} [modify] https://crrev.com/578602575ab3499947834e52b6bb2c800ab5f2be/chrome/test/data/webui/cr_elements/cr_checkbox_test.js [modify] https://crrev.com/578602575ab3499947834e52b6bb2c800ab5f2be/chrome/test/data/webui/cr_elements/cr_toggle_test.js [modify] https://crrev.com/578602575ab3499947834e52b6bb2c800ab5f2be/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.js [modify] https://crrev.com/578602575ab3499947834e52b6bb2c800ab5f2be/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.js
,
May 15 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nyerramilli@chromium.org
, May 14 2018