Extensions API button strip has margin instead of padding
Reported by
bran...@promotionsonly.com.au,
May 14 2018
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36 Steps to reproduce the problem: 1. Navigate to chrome://extensions 2. Above the enable/disable switch of each extension there is a gap of where a border bottom should span to about 90% of the entire parent's width. 3. What is the expected behavior? The border bottom above the enable/disable switch of each extension should span the entire width of the parent element. What went wrong? #button-strip requires -webkit-padding-end: 20px; although instead it was -webkit-margin-end: 20px; Did this work before? No Does this work in other browsers? Yes Chrome version: 66.0.3359.139 Channel: n/a OS Version: 10.0 Flash Version:
,
May 14 2018
Apologies for the wrong label, when it asks are you a web developer, those other labels disappear, sure it may have been a design issue but hey I am a web developer. :P
,
May 14 2018
,
May 14 2018
,
May 15 2018
brandon@ - Thanks for filing the issue...!! Could you please provide an expected/actual screenshot for better understanding of the issue. This will help us in triaging the issue further from TE-end. Thanks...!!
,
May 15 2018
Attached in the email in an attempt to reply from my phone.
,
May 15 2018
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 21 2018
Able to reproduce the issue on reported version 66.0.3359.139, on latest stable 66.0.3359.181 and latest beta 67.0.3396.48 using Mac 10.13.3, Windows 10 and Ubuntu 14.04. In latest canary 68.0.3436.0 separator line is removed. ref bug https://bugs.chromium.org/p/chromium/issues/detail?id=842002&desc=2. As issue is reproducible from TE end marking this as Untriaged and cc'ing author @aee from 842002 bug for further inputs.
,
May 21 2018
Whoops, my apologies I forgot to check Canary
,
May 21 2018
The separator is gone, so the issue is no longer apparent. Even so, I think it makes sense to clean up the styling. Thanks for reporting!
,
May 21 2018
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7335b3079c4b9b9850ce0a8a347f32dd6b37c3a9 commit 7335b3079c4b9b9850ce0a8a347f32dd6b37c3a9 Author: Esmael El-Moslimany <aee@chromium.org> Date: Tue May 22 21:27:11 2018 MD Extension: change margin-end to padding-end Bug: 842582 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8b64c868ef6a4437116ebb2a363757a77b8674d3 Reviewed-on: https://chromium-review.googlesource.com/1067487 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#560781} [modify] https://crrev.com/7335b3079c4b9b9850ce0a8a347f32dd6b37c3a9/chrome/browser/resources/md_extensions/item.html
,
May 22 2018
,
May 23 2018
Able to reproduce the issue on reported version hence verifying the fix on latest canary 68.0.3438.0 using Windows10 and Ubuntu 14.04. In build without fix observing -webkit-margin-end: 20px; on inspecting but on latest canary observing -webkit-padding-end: 20px; in Linux and Windows. Unable to verify this issue on Mac due to blocking issue 845807 (devtools is seen blank). Fix is working as expected in Linux and Windows. As unable to verify on Mac not adding Verified labels. Thanks! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by phistuck@chromium.org
, May 14 2018Labels: -Hotlist-Interop