Terminal starts in wrong profile |
|||
Issue descriptionChrome version: (copy from chrome://version) OS: Chrome Repro steps: 1. Have terminal set up in profile #1 2. Boot fresh and sign in to profile #1 3. Sign in (another user) to profile #2 4. Switch back to profile #1 5. Click "Terminal" in launcher. Expected: Terminal should launch against previously set up container in profile #1. Actual: After a really long time I got a terminal for a new container in profile #2, the window appears on profile #1 but has the avatar for profile #2.
,
May 14 2018
Was this canary or dev chrome?
,
May 14 2018
Ah sorry, the crostini-bug link seems to not include the information that crbug.com/new does. dev-channel: Chrome Version: 68.0.3416.0 OS Version: 10635.0.0
,
May 14 2018
Thank you. Trying now to repro from tip-of-tree
,
May 14 2018
I can't repro this as written from Tip of tree. However, if we add 3.a. Click Terminal in launcher (while signed in to profile #2) 4. Switch back to profile #1 (before a Terminal comes up), Then I get the Terminal with avatar for profile #2 showing up in profile #1
,
May 14 2018
Issue 839244 has been merged into this issue.
,
May 14 2018
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d79d513758271479430816a5db15a5a414901b1 commit 3d79d513758271479430816a5db15a5a414901b1 Author: Nicholas Verne <nverne@chromium.org> Date: Tue May 15 06:29:58 2018 Restrict crostini UI to primary profile Crostini multiprofile support is going to wait until the successor for multiprofile is landed on ChromeOS. Until then, we restrict Crostini to the primary (i.e. first signed in) profile per session. This means that you can still have Linux containers per profile, but to use then you need to sign out then sign in to the desired profile. Note, this prevents UI from being shown to the non-primary profile. It doesn't prevent non-primary users from using crosh and vmc. Bug: 842561 Change-Id: I119359b332e7a3afa02071c1e9d9e6f41164fe4d Reviewed-on: https://chromium-review.googlesource.com/1058738 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#558627} [modify] https://crrev.com/3d79d513758271479430816a5db15a5a414901b1/chrome/browser/chromeos/crostini/crostini_util.cc
,
May 16 2018
Issue 843193 has been merged into this issue.
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/787965b98618fcf687109119b0c8a825c3f889a7 commit 787965b98618fcf687109119b0c8a825c3f889a7 Author: Nicholas Verne <nverne@chromium.org> Date: Fri May 18 05:24:43 2018 Roll src/third_party/cros_system_api/ ce8067bec..40aa75e44 (3 commits) https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/ce8067becb65..40aa75e44dda $ git log ce8067bec..40aa75e44 --date=short --no-merges --format='%ad %ae %s' 2018-05-16 nverne Add owner_id to messages that need it. 2018-03-30 derat system_api: Remove org.chromium.LibCrosService constants. 2018-05-07 emaxx cryptohome: Pass D-Bus delegate for challenge keys Created with: roll-dep src/third_party/cros_system_api Bug: 842561 Change-Id: Ie5d14afb8bed77a42d54446f1b36645640f3aecc Reviewed-on: https://chromium-review.googlesource.com/1064655 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#559807} [modify] https://crrev.com/787965b98618fcf687109119b0c8a825c3f889a7/DEPS
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37c9fcae984bc45d2ae487d32bc41c66ec7368af commit 37c9fcae984bc45d2ae487d32bc41c66ec7368af Author: Nicholas Verne <nverne@chromium.org> Date: Tue May 22 01:02:06 2018 Support the owner_id field for CrostiniManager methods. This allows Crostini to "play nice" with current multiprofile situations. Note that Concierge itself needs to change to support owner_id too. Bug: 842561 Change-Id: Ie71fa5e7015f940b50fc80eb2188ae389d2a8a12 Reviewed-on: https://chromium-review.googlesource.com/1065835 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#560438} [modify] https://crrev.com/37c9fcae984bc45d2ae487d32bc41c66ec7368af/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/37c9fcae984bc45d2ae487d32bc41c66ec7368af/chrome/browser/chromeos/crostini/crostini_manager.h [modify] https://crrev.com/37c9fcae984bc45d2ae487d32bc41c66ec7368af/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc [modify] https://crrev.com/37c9fcae984bc45d2ae487d32bc41c66ec7368af/chrome/browser/chromeos/crostini/crostini_registry_service.cc [modify] https://crrev.com/37c9fcae984bc45d2ae487d32bc41c66ec7368af/chrome/browser/chromeos/crostini/crostini_registry_service.h [modify] https://crrev.com/37c9fcae984bc45d2ae487d32bc41c66ec7368af/chrome/browser/chromeos/crostini/crostini_remover.cc [modify] https://crrev.com/37c9fcae984bc45d2ae487d32bc41c66ec7368af/chrome/browser/chromeos/crostini/crostini_util.cc
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/560b33dc46e65da5ce3f8f6d86c03a019dc6695e commit 560b33dc46e65da5ce3f8f6d86c03a019dc6695e Author: Nicholas Verne <nverne@chromium.org> Date: Wed May 23 10:03:30 2018 Roll src/third_party/cros_system_api/ 40aa75e44..f6223168d (3 commits) https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/40aa75e44dda..f6223168d99e $ git log 40aa75e44..f6223168d --date=short --no-merges --format='%ad %ae %s' 2018-05-22 nverne Add owner_id to message StartVmRequest 2018-05-21 brunokim Notify ARC on boot that supervision state changed. 2018-05-21 yusukes arc: Remove StartArcInstanceRequest message Created with: roll-dep src/third_party/cros_system_api Bug: 842561 Change-Id: Id86b391b25cfc46feb2af21e8fa84a75a660c976 Reviewed-on: https://chromium-review.googlesource.com/1070010 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#561019} [modify] https://crrev.com/560b33dc46e65da5ce3f8f6d86c03a019dc6695e/DEPS
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c998d0d7624020683f18d4c384c26b22c77c8df commit 0c998d0d7624020683f18d4c384c26b22c77c8df Author: Nicholas Verne <nverne@chromium.org> Date: Fri May 25 01:41:22 2018 Sets owner_id in CrostiniManager::StartTerminaVm. This lets Concierge correctly associate a VM with the current user Bug: 842561 Change-Id: Id313c9d7514575850ba4961afe968acd7d797ec9 Reviewed-on: https://chromium-review.googlesource.com/1072210 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#561730} [modify] https://crrev.com/0c998d0d7624020683f18d4c384c26b22c77c8df/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/0c998d0d7624020683f18d4c384c26b22c77c8df/chrome/browser/chromeos/crostini/crostini_manager.h [modify] https://crrev.com/0c998d0d7624020683f18d4c384c26b22c77c8df/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/3ff75f5d53e9aeadb1c88ef635e5ce7b0186b06b commit 3ff75f5d53e9aeadb1c88ef635e5ce7b0186b06b Author: Nicholas Verne <nverne@chromium.org> Date: Wed May 30 19:50:47 2018 vm_host_tools: Keys Concierge's |vms_| by (owner_id, vm_name) This prevents vm collisions in multiprofile situations when the same vm name has been used by different profiles. BUG= chromium:842561 TEST=manual testing. Change-Id: I49130f6248d81d9bdeebf94a70eb7e23d9201cac Reviewed-on: https://chromium-review.googlesource.com/1071328 Commit-Ready: Nicholas Verne <nverne@chromium.org> Tested-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/3ff75f5d53e9aeadb1c88ef635e5ce7b0186b06b/vm_tools/concierge/service.h [modify] https://crrev.com/3ff75f5d53e9aeadb1c88ef635e5ce7b0186b06b/vm_tools/vsh/vsh.cc [modify] https://crrev.com/3ff75f5d53e9aeadb1c88ef635e5ce7b0186b06b/vm_tools/concierge/service.cc [modify] https://crrev.com/3ff75f5d53e9aeadb1c88ef635e5ce7b0186b06b/vm_tools/concierge/client.cc [modify] https://crrev.com/3ff75f5d53e9aeadb1c88ef635e5ce7b0186b06b/crosh/crosh
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec70c0c324e8d3898cc504d83743974b516b37b0 commit ec70c0c324e8d3898cc504d83743974b516b37b0 Author: Nicholas Verne <nverne@chromium.org> Date: Thu May 31 00:53:15 2018 Crostini's terminal passes cryptohome_id to vmshell. This ensures that the underlying vsh implementation connects to the correct VM via Concierge service. Another CL impelments the Concierge side of this change. Bug: 842561 Change-Id: I9d0f84cffd111e86760369c3f7d060580aef44b3 Reviewed-on: https://chromium-review.googlesource.com/1074803 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#563093} [modify] https://crrev.com/ec70c0c324e8d3898cc504d83743974b516b37b0/chrome/browser/chromeos/crostini/crostini_manager.cc
,
Jun 13 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by benwells@chromium.org
, May 14 2018Labels: -Restrict-View-Google
Owner: nverne@chromium.org
Status: Assigned (was: Untriaged)