New issue
Advanced search Search tips

Issue 842553 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Compat

Blocking:
issue 680046



Sign in to add a comment

Fix referrer policy on dedicated workers loaded as module scripts

Project Member Reported by nhiroki@chromium.org, May 14 2018

Issue description

Currently there are no tests for referrer policy on dedicated workers loaded as module scripts.
 
Cc: hirosh...@chromium.org japhet@chromium.org kouhei@chromium.org
We may need to fix this issue before adding tests:

"Interestingly, after the off-the-main-thread module loading patch is landed (see c#37), module workers start fetching the top-level module script with a referrer that is the same with the request's URL. Before the patch, the referrer was the parent document's URL. I'll investigate it next week."

Copied from https://bugs.chromium.org/p/chromium/issues/detail?id=680046#c38
Note for c#1: The referrer is set in BaseFetchContext::AddAdditionalRequestHeaders. GetOutgoingReferrer() asks an associated ExecutionContext about the referrer. Before the patch, it's Document. After the patch, it's WorkerGlobalScope. This is the reason why the top-level module script is loaded using its URL as referrer.
This CL seems to affect this issue:
https://chromium-review.googlesource.com/c/chromium/src/+/1056792/10

I'll wait until the CL lands.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b

commit b85ac4c9224230709fcc2fa9328b45c7ba4ae16b
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Jun 01 03:34:15 2018

ES Modules: Implement the SettingsObject concept

This is a cleanup CL that doesn't change existing behavior, so there're no
additional tests.

This implements the "settings object" concept defined in the HTML spec:
https://html.spec.whatwg.org/multipage/webappapis.html#settings-object

A motivation of this change is to split the Modulator into the "fetch client
settings object" and the "module map settings object" so that module loading,
especially for workers and worklets, can be implemented in a saner and more
spec compatible way.

Specifically, this CL implements SettingsObject class, passes an instance of
the class as "fetch client settings object" to module loader classes, and
replaces Modulator::GetSecurityOrigin() and GetReferrerPolicy() with
SettingsObject's functions. The "module map settings object" will be implemented
in subsequent CLs.

Change-Id: I3028be4825745bf975c4ac2820358fb9c2c0974c
Bug:  842553 , 845285
Reviewed-on: https://chromium-review.googlesource.com/1080441
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563522}
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/loader/link_loader_test.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/loader/modulescript/module_script_loader.h
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/loader/modulescript/module_script_loader_registry.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/loader/modulescript/module_script_loader_registry.h
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.h
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_test.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/BUILD.gn
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/dynamic_module_resolver.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/dynamic_module_resolver_test.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/modulator.h
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/modulator_impl_base.h
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/module_map.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/module_map.h
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/module_map_test.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/script_loader.h
[add] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/settings_object.cc
[add] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/settings_object.h
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/worklet_modulator_impl.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/script/worklet_modulator_impl.h
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/testing/dummy_modulator.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/testing/dummy_modulator.h
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
[modify] https://crrev.com/b85ac4c9224230709fcc2fa9328b45c7ba4ae16b/third_party/blink/renderer/core/workers/worklet_global_scope.cc

Summary: Fix referrer policy on dedicated workers loaded as module scripts (was: Add WPTs for referrer policy on dedicated workers loaded as module scripts)
I found another issue. Dedicated Workers need to have its own referrer policy served by response's HTTP header. For classic script loading this is correctly set in DedicatedWorker:OnFinished(), but for module script loading it's not set.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/030f5aa2dfc638b4d24addf1f8c91a25898a2093

commit 030f5aa2dfc638b4d24addf1f8c91a25898a2093
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Tue Jun 05 06:42:02 2018

Worker: Pass Document's SettingsObject to WorkletGlobalScope as "fetch_client_settings_object"

This CL makes Document serve its settings object to WorkletGlobalScope. This
SettingsObject is used as "fetch_client_settings_object" in module loading for a
top-level worklet script and static imports. This involves a thread hop from the
main thread to a worker thread, so this CL makes SettingsObject
cross-thread-transferable.

Before this CL, the "fetch_client_settings_object" for worklets is generated
from Document's SecurityOrigin and WorkletGlobalScope's ReferrerPolicy. This
looks twisted, but worked correctly because WorkletGlobalScope has the same
ReferrerPolicy with Document's ReferrerPolicy. This CL straightens it by
providing the settings object from Document.

Implementation notes:
- This changes the SettingsObject class from GC-managed to non-GC-managed for
  making it cross-thread-transferable in a sanner manner.
- This adds class-level comments on SettingsObject that the class takes a
  snapshot of ExecutionContext's states and doesn't track updates of the states.

Bug:  842553 , 845285
Change-Id: I56ce1c52f3fe43a5be7572d5af38b5444f3cbc10
Reviewed-on: https://chromium-review.googlesource.com/1082143
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564379}
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope_proxy.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope_proxy.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/loader/link_loader_test.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/loader/modulescript/module_script_loader.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/loader/modulescript/module_script_loader_registry.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/loader/modulescript/module_script_loader_registry.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_test.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/script/dynamic_module_resolver.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/script/dynamic_module_resolver_test.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/script/modulator.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/script/modulator_impl_base.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/script/module_map.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/script/module_map.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/script/module_map_test.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/script/script_loader.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/script/settings_object.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/script/settings_object.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/testing/dummy_modulator.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/testing/dummy_modulator.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/workers/threaded_worklet_messaging_proxy.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/workers/threaded_worklet_messaging_proxy.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/workers/threaded_worklet_object_proxy.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/workers/threaded_worklet_object_proxy.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/workers/worklet.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/workers/worklet_global_scope.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/workers/worklet_global_scope.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/core/workers/worklet_global_scope_proxy.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope_proxy.cc
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope_proxy.h
[modify] https://crrev.com/030f5aa2dfc638b4d24addf1f8c91a25898a2093/third_party/blink/renderer/platform/weborigin/referrer_policy.h

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be2342db40eee600122eaaf9a8b5e2023e7dd704

commit be2342db40eee600122eaaf9a8b5e2023e7dd704
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Jun 06 07:04:48 2018

Worker: Add referrer tests for ES Modules on dedicated workers

Referrer handling spans multiple algorithms in multiple specs, so I leave only
the entry points of them.

For top-level module script loading and static imports, referrer is determined
based on the "outside settings":

  "Fetch a module worker script graph given url, outside settings, destination,
  the value of the credentials member of options, and inside settings."

https://html.spec.whatwg.org/multipage/workers.html#worker-processing-model

For dynamic imports, referrer is determined based on the "referencing script's
settings object". In this case, it's "inside settings":

  Step 2.4: "Fetch a module script graph given url, referencing script's settings object,
  "script", and options. Wait until the algorithm asynchronously completes with
  result."

https://html.spec.whatwg.org/multipage/webappapis.html#hostimportmoduledynamically(referencingscriptormodule,-specifier,-promisecapability)

These tests are still failing. Subsequent CLs will fix them.

Bug:  842553 
Change-Id: I3855b91c7e6ba93f5c99fb63b24b6274e6b43211
Reviewed-on: https://chromium-review.googlesource.com/1088339
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564811}
[add] https://crrev.com/be2342db40eee600122eaaf9a8b5e2023e7dd704/third_party/WebKit/LayoutTests/external/wpt/workers/modules/dedicated-worker-import-referrer-expected.txt
[add] https://crrev.com/be2342db40eee600122eaaf9a8b5e2023e7dd704/third_party/WebKit/LayoutTests/external/wpt/workers/modules/dedicated-worker-import-referrer.html
[add] https://crrev.com/be2342db40eee600122eaaf9a8b5e2023e7dd704/third_party/WebKit/LayoutTests/external/wpt/workers/modules/resources/dynamic-import-remote-origin-referrer-checker-worker.sub.js
[add] https://crrev.com/be2342db40eee600122eaaf9a8b5e2023e7dd704/third_party/WebKit/LayoutTests/external/wpt/workers/modules/resources/dynamic-import-same-origin-referrer-checker-worker.js
[add] https://crrev.com/be2342db40eee600122eaaf9a8b5e2023e7dd704/third_party/WebKit/LayoutTests/external/wpt/workers/modules/resources/referrer-checker.py
[add] https://crrev.com/be2342db40eee600122eaaf9a8b5e2023e7dd704/third_party/WebKit/LayoutTests/external/wpt/workers/modules/resources/static-import-remote-origin-referrer-checker-worker.sub.js
[add] https://crrev.com/be2342db40eee600122eaaf9a8b5e2023e7dd704/third_party/WebKit/LayoutTests/external/wpt/workers/modules/resources/static-import-same-origin-referrer-checker-worker.js

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c475a689dcfb2886bdacff8b146dabd7ce43ac8a

commit c475a689dcfb2886bdacff8b146dabd7ce43ac8a
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Jun 07 06:10:41 2018

Worker: Use Document's SettingsObject for top-level module script loading on dedicated workers

This CL makes Document serve its settings object ("outside settings") to
WorkerGlobalScope based on the following HTML spec:

  Step 13. "Fetch a module worker script graph given url, outside settings,
  destination, the value of the credentials member of options, and inside
  settings."
  https://html.spec.whatwg.org/multipage/workers.html#worker-processing-model

This SettingsObject is used as "fetch client settings object" for top-level
module script loading and static imports.

Before this CL, WorkerGlobalScope's settings object ("inside_settings_object")
is used as "fetch client settings object". This is obviously wrong and fails
some web-platform-tests. This change fixes them.

Change-Id: I87a78f38308e262425b848d99dc617dbddeb81e7
Bug:  842553 , 845285
Reviewed-on: https://chromium-review.googlesource.com/1084133
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565199}
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/WebKit/LayoutTests/external/wpt/workers/modules/dedicated-worker-import-referrer-expected.txt
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/WebKit/LayoutTests/external/wpt/workers/modules/dedicated-worker-import-referrer.html
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.cc
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.h
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.h
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/core/workers/shared_worker_global_scope.cc
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/core/workers/shared_worker_global_scope.h
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/core/workers/worker_global_scope.h
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/core/workers/worker_thread.cc
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/core/workers/worker_thread.h
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/core/workers/worker_thread_test_helper.h
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.cc
[modify] https://crrev.com/c475a689dcfb2886bdacff8b146dabd7ce43ac8a/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.h

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08c00914b3530b1ebcd69c0b8dd34c189a453cae

commit 08c00914b3530b1ebcd69c0b8dd34c189a453cae
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Jun 13 08:35:19 2018

ES Modules: Separate ModuleScriptFetcher for Documents and Worklets

This is a cleanup CL and doesn't change behavior except LAPIs support (see
below).

Before this CL, ModuleScriptFetcher is an implementation of module script fetch
for <script type='module'> on Documents, and WorkletModuleScriptFetcher is a
subclass of ModuleScriptFetcher that implements the custom fetch hook for
Worklets. This override reduces code duplication, but also makes it difficult to
read code.

After this CL, ModuleScriptFetcher becomes just an interface.
DocumentModuleScriptFetcher implements it for Documents, and
WorkletModuleScriptFetcher implements it for Worklets. This separation makes it
easier to read code and to add a new variant of ModuleScriptFetcher for Workers,
there're some duplicate code among DocumentModuleScriptFetcher and
WorkletModuleScriptFetcher though.

Note that this CL tentatively drops LAPIs support for worklets. This is safe
because it has been flagged feature and not ready for worklets so far. We'll
re-add the support after refactoring around ModuleScriptFetcher.

Change-Id: I60fa46ebd86e046da811f018219cdd02411529a8
Bug:  842553 
Reviewed-on: https://chromium-review.googlesource.com/1096919
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566760}
[modify] https://crrev.com/08c00914b3530b1ebcd69c0b8dd34c189a453cae/third_party/blink/renderer/core/loader/BUILD.gn
[add] https://crrev.com/08c00914b3530b1ebcd69c0b8dd34c189a453cae/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[add] https://crrev.com/08c00914b3530b1ebcd69c0b8dd34c189a453cae/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.h
[modify] https://crrev.com/08c00914b3530b1ebcd69c0b8dd34c189a453cae/third_party/blink/renderer/core/loader/modulescript/module_script_fetcher.cc
[modify] https://crrev.com/08c00914b3530b1ebcd69c0b8dd34c189a453cae/third_party/blink/renderer/core/loader/modulescript/module_script_fetcher.h
[modify] https://crrev.com/08c00914b3530b1ebcd69c0b8dd34c189a453cae/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/08c00914b3530b1ebcd69c0b8dd34c189a453cae/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/08c00914b3530b1ebcd69c0b8dd34c189a453cae/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.h
[modify] https://crrev.com/08c00914b3530b1ebcd69c0b8dd34c189a453cae/third_party/blink/renderer/core/script/document_modulator_impl.cc
[modify] https://crrev.com/08c00914b3530b1ebcd69c0b8dd34c189a453cae/third_party/blink/renderer/core/script/worker_modulator_impl.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/760ce10e589c28507cc6da0cd1294e95dfcba1d8

commit 760ce10e589c28507cc6da0cd1294e95dfcba1d8
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Jun 13 17:03:21 2018

Worker: Set ReferrerPolicy for dedicated workers after top-level module script loading

Before this CL, referrer policy for dedicated workers loaded as modules scripts
hasn't been set. This has failed referrer tests.

After this CL, it's set by the ReferrerPolicy HTTP header on a response of the
worker's top-level module script based on the HTML spec:

  Step 13.5: "Set worker global scope's referrer policy to the result of parsing the
  `Referrer-Policy` header of response."

https://html.spec.whatwg.org/multipage/workers.html#worker-processing-model

Bug:  842553 
Change-Id: Iaabaca6b46a2fa41835682787de8de527e6481d3
Reviewed-on: https://chromium-review.googlesource.com/1084417
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566880}
[modify] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/WebKit/LayoutTests/external/wpt/workers/modules/dedicated-worker-import-referrer-expected.txt
[modify] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/blink/renderer/core/loader/BUILD.gn
[modify] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.h
[modify] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/blink/renderer/core/loader/modulescript/module_script_fetcher.h
[modify] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
[add] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[add] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.h
[modify] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.h
[modify] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/blink/renderer/core/script/worker_modulator_impl.cc
[modify] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/blink/renderer/core/workers/worker_global_scope.cc
[modify] https://crrev.com/760ce10e589c28507cc6da0cd1294e95dfcba1d8/third_party/blink/renderer/core/workers/worklet_module_responses_map_test.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91d0f68db814683fc61f7c0d5b9ad779a95e71b9

commit 91d0f68db814683fc61f7c0d5b9ad779a95e71b9
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Jun 14 04:10:05 2018

Do not plumb Modulator through ModuleTreeLinkerRegistry

To remove indirect layers around Modulator.

Bug:  842553 
Change-Id: Ib4d2d6a3e348723cb9a9bd980b616ea4517dab3b
Reviewed-on: https://chromium-review.googlesource.com/1080007
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567126}
[modify] https://crrev.com/91d0f68db814683fc61f7c0d5b9ad779a95e71b9/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc
[modify] https://crrev.com/91d0f68db814683fc61f7c0d5b9ad779a95e71b9/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h
[modify] https://crrev.com/91d0f68db814683fc61f7c0d5b9ad779a95e71b9/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.cc
[modify] https://crrev.com/91d0f68db814683fc61f7c0d5b9ad779a95e71b9/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.h
[modify] https://crrev.com/91d0f68db814683fc61f7c0d5b9ad779a95e71b9/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_test.cc
[modify] https://crrev.com/91d0f68db814683fc61f7c0d5b9ad779a95e71b9/third_party/blink/renderer/core/script/modulator_impl_base.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7761a45523db17b4fd228b4172bd323b50b1d0e

commit b7761a45523db17b4fd228b4172bd323b50b1d0e
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Jun 14 06:19:31 2018

Do not plumb Modulator through ModuleScriptLoader

To remove indirect layers around Modulator.

Bug:  842553 
Change-Id: Ie307c9f91ead00e260da156d6ae283131316d7eb
Reviewed-on: https://chromium-review.googlesource.com/1080032
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567169}
[modify] https://crrev.com/b7761a45523db17b4fd228b4172bd323b50b1d0e/third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
[modify] https://crrev.com/b7761a45523db17b4fd228b4172bd323b50b1d0e/third_party/blink/renderer/core/loader/modulescript/module_script_loader.h
[modify] https://crrev.com/b7761a45523db17b4fd228b4172bd323b50b1d0e/third_party/blink/renderer/core/loader/modulescript/module_script_loader_registry.cc
[modify] https://crrev.com/b7761a45523db17b4fd228b4172bd323b50b1d0e/third_party/blink/renderer/core/loader/modulescript/module_script_loader_registry.h
[modify] https://crrev.com/b7761a45523db17b4fd228b4172bd323b50b1d0e/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/b7761a45523db17b4fd228b4172bd323b50b1d0e/third_party/blink/renderer/core/script/modulator_impl_base.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/000b11bd2619e8a90f347edbf77474fee2b21a15

commit 000b11bd2619e8a90f347edbf77474fee2b21a15
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Jun 18 06:24:33 2018

ES Modules: Set referrer for top-level module script in ModuleScriptLoader

Before this CL, referrer for top-level module script is set in
BaseFetchContext::AddAdditionalRequestHeaders() using
ExecutionContext::GetOutgoingReferrer(). This works for documents, but doesn't
for workers because this execution context is corresponding to "module map
settings object", not "fetch client settings object".

To fix this, this CL sets the referrer for top-level module script using "fetch
client settings object" in ModuleScriptLoader as the spec defines.

Change-Id: I0878b13febdae4ee2dc56c998e7f2c100e9c1ba7
Bug:  842553 
Reviewed-on: https://chromium-review.googlesource.com/1102236
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567937}
[delete] https://crrev.com/df6364f85935219e829cb94df310d399b067b945/third_party/WebKit/LayoutTests/external/wpt/workers/modules/dedicated-worker-import-referrer-expected.txt
[modify] https://crrev.com/000b11bd2619e8a90f347edbf77474fee2b21a15/third_party/WebKit/LayoutTests/external/wpt/workers/modules/dedicated-worker-import-referrer.html
[modify] https://crrev.com/000b11bd2619e8a90f347edbf77474fee2b21a15/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/000b11bd2619e8a90f347edbf77474fee2b21a15/third_party/blink/renderer/core/loader/link_loader_test.cc
[modify] https://crrev.com/000b11bd2619e8a90f347edbf77474fee2b21a15/third_party/blink/renderer/core/loader/modulescript/module_script_fetch_request.h
[modify] https://crrev.com/000b11bd2619e8a90f347edbf77474fee2b21a15/third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
[modify] https://crrev.com/000b11bd2619e8a90f347edbf77474fee2b21a15/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc
[modify] https://crrev.com/000b11bd2619e8a90f347edbf77474fee2b21a15/third_party/blink/renderer/core/script/fetch_client_settings_object_snapshot.cc
[modify] https://crrev.com/000b11bd2619e8a90f347edbf77474fee2b21a15/third_party/blink/renderer/core/script/fetch_client_settings_object_snapshot.h

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b789471f1773abbbb51d0239475439f5f35b070f

commit b789471f1773abbbb51d0239475439f5f35b070f
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Jun 25 05:14:59 2018

ES Modules: Use an appropriate referrer policy for module script loading

This CL fixes ReferrerPolicy handling in module script loading. Before this CL,
FetchClientSettingsObjectSnapshot's referrer policy is used, but this is wrong.
The spec requires to use ScriptFetchOptions' referrer policy.

  // The "set up the module script request" algorithm:
  "Set request's cryptographic nonce metadata to options's cryptographic nonce,
  ..., and its referrer policy to options's referrer policy."
  https://html.spec.whatwg.org/multipage/webappapis.html#set-up-the-module-script-request

Specifically, this CL introduces |referrer_policy_| field in ScriptFetchOptions
class as spec'ed and propagates it to the entire path of module script loading.

ScriptFetchOptions's referrer policy can be set to following values:

- <script>'s "referrerpolicy" attribute is used for <script type='module'>. This
  hasn't been implemented yet (see  https://crbug.com/841673 ), so the current
  document's referrer policy is used to keep the backward compatibility.

  // The "prepare a script" algorithm:
  "20. Let referrer policy be the current state of the element's referrerpolicy
  content attribute."
  "22. Let options be a script fetch options whose cryptographic nonce is
  cryptographic nonce, ..., and referrer policy is referrer policy."
  https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script

- <link>'s "referrerpolicy" attribute is used for modulepreload.

  // The "Link type "modulepreload"" algorithm:
  "9. Let referrer policy be the current state of the element's referrerpolicy
  attribute."
  "10. Let options be a script fetch options whose cryptographic nonce is
  cryptographic nonce, ..., and referrer policy is referrer policy."
  https://html.spec.whatwg.org/multipage/links.html#link-type-modulepreload

- The default referrer policy is used for module workers and worklets. This is
  the reason why this CL changes test expectations of workers and worklets.

  // The "fetch a module worker script graph" algorithm:
  "2. Let options be a script fetch options whose cryptographic nonce is the
  empty string, ..., and referrer policy is the empty string."
  https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-module-worker-script-tree

Change-Id: Ic0f9e6667cd1b84f74d86fcc948451c1d2f8191f
Bug:  842553 ,  855963 
Reviewed-on: https://chromium-review.googlesource.com/1111743
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569967}
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/WebKit/LayoutTests/external/wpt/workers/modules/dedicated-worker-import-referrer.html
[delete] https://crrev.com/b39bd8924173bd52fa62405efd47e6ba01aaf796/third_party/WebKit/LayoutTests/external/wpt/worklets/animation-worklet-referrer.https-expected.txt
[delete] https://crrev.com/b39bd8924173bd52fa62405efd47e6ba01aaf796/third_party/WebKit/LayoutTests/external/wpt/worklets/layout-worklet-referrer.https-expected.txt
[delete] https://crrev.com/b39bd8924173bd52fa62405efd47e6ba01aaf796/third_party/WebKit/LayoutTests/external/wpt/worklets/paint-worklet-referrer.https-expected.txt
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/referrer-checker.py
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/referrer-tests.js
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/referrer-window.html
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/blink/renderer/bindings/core/v8/referrer_script_info.cc
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/blink/renderer/bindings/core/v8/referrer_script_info.h
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/blink/renderer/bindings/core/v8/referrer_script_info_test.cc
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/blink/renderer/core/script/dynamic_module_resolver.cc
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
[modify] https://crrev.com/b789471f1773abbbb51d0239475439f5f35b070f/third_party/blink/renderer/platform/loader/fetch/script_fetch_options.h

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/648ee420f51574ca14846409eb3581b8da03e3fc

commit 648ee420f51574ca14846409eb3581b8da03e3fc
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Tue Jun 26 09:42:21 2018

ES Modules: Introduce ModuleScriptCustomFetchType

This CL introduces ModuleScriptCustomFetchType enums that indicate which custom
fetch hook is specified. Modulator::CreateModuleScriptFetcher() creates a
ModuleScriptFetcher instance based on the enum. For example, WorkerModulatorImpl
creates WorkerModuleScriptFetcher for new Worker() and
DocumentModuleScriptFetcher for dynamic import.

The main motivation of this change is to avoid settings ReferrerPolicy in
WorkerGlobalScope multiple times in WorkerModuleScriptFetcher. See changes there
for details.

Change-Id: I964276e5fc1d2d364a4484a5a47ea5b3a700fbf7
Bug:  842553 
Reviewed-on: https://chromium-review.googlesource.com/1113078
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570359}
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/loader/link_loader_test.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.h
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/loader/modulescript/module_script_loader.h
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_test.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/document_modulator_impl.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/document_modulator_impl.h
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/dynamic_module_resolver.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/dynamic_module_resolver_test.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/modulator.h
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/modulator_impl_base.h
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/module_map.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/module_map.h
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/module_map_test.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/worker_modulator_impl.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/worker_modulator_impl.h
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/worklet_modulator_impl.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/script/worklet_modulator_impl.h
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/testing/dummy_modulator.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/testing/dummy_modulator.h
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
[modify] https://crrev.com/648ee420f51574ca14846409eb3581b8da03e3fc/third_party/blink/renderer/core/workers/worklet_global_scope.cc

Labels: M-69 Target-69
Status: Fixed (was: Started)

Sign in to add a comment