Test Crostini app integration |
|||||||
Issue descriptionWe need tests for integration of Crostini apps (the registry) with the app list, shelf and search (inc. the recents list). If possible, we should also try to add tests for our icon handling, which involves saving and loading icons to disk. The main things we would like for this are: Testing framework: - Mocking launching of terminal and apps so it creates a shelf entry App list: - Terminal icon only appears when Terminal is installed - Installing/uninstalling Crostini - Installing/updating/removing apps - Can pin to shelf Shelf: - Entries show up with the right title when launched - Can pin running apps, shelf entry correctly associates with launched apps/spinner - Pins persist on log-in/out - Spinner shows and... -- Vanishes correctly when app launches -- Doesn't remove shelf entry when app launches (i.e. if not pinned and another shelf item is created in the meanwhile, they don't re-order) - Shelf entries (and windows) disappear when switching profiles, re-appear when switching back Search: - Terminal icon only appears when Terminal is installed or exact search for 'Terminal' (also see bug 840699 ) - Search works - The Terminal and Crostini apps both appear correctly in the recents list (end-to-end testing is out of scope for this bug, see bug 849438 )
,
May 14 2018
,
May 14 2018
,
May 29 2018
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/093b1afb950617e8910030398500786930a8bc36 commit 093b1afb950617e8910030398500786930a8bc36 Author: Timothy Loh <timloh@chromium.org> Date: Mon Jun 04 04:46:21 2018 Add basic tests for Crostini App List integration This CL adds basic tests for integration of Crostini Apps with the App List. In particular, we check that enabling/disabling Crostini shows/ hides the Terminal app, and installing/updating/removing apps is also appropriately reflected in the app list. This CL also adds a CrostiniTestHelper class, to aid testing Crostini app integration. The CrostiniRegistryService intentionally does not use the CrostiniTestHelper aside from the proto-building helper functions to keep it explicit about what it is testing. Bug: 842552 Change-Id: I0794a2a966eb5446775f5227b1ce18046f25bfb5 Reviewed-on: https://chromium-review.googlesource.com/1080430 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#563999} [modify] https://crrev.com/093b1afb950617e8910030398500786930a8bc36/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/093b1afb950617e8910030398500786930a8bc36/chrome/browser/chromeos/crostini/crostini_registry_service_unittest.cc [add] https://crrev.com/093b1afb950617e8910030398500786930a8bc36/chrome/browser/chromeos/crostini/crostini_test_helper.cc [add] https://crrev.com/093b1afb950617e8910030398500786930a8bc36/chrome/browser/chromeos/crostini/crostini_test_helper.h [modify] https://crrev.com/093b1afb950617e8910030398500786930a8bc36/chrome/browser/ui/app_list/crostini/crostini_app_model_builder.cc [add] https://crrev.com/093b1afb950617e8910030398500786930a8bc36/chrome/browser/ui/app_list/crostini/crostini_app_model_builder_unittest.cc [modify] https://crrev.com/093b1afb950617e8910030398500786930a8bc36/chrome/test/BUILD.gn
,
Jun 6 2018
,
Jul 27
<triage>Is this done, or should it be moved to M70?</triage>
,
Jul 30
Moving to 70 (I think there's additional spinner stuff to test now. I'm looking at 868221 at the moment, but do still hope to get to this soon)
,
Sep 12
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by timloh@chromium.org
, May 14 2018