New issue
Advanced search Search tips

Issue 842551 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug

Blocked on:
issue 847357

Blocking:
issue 850825



Sign in to add a comment

Implement IsHistoryNavigation attribute on Request

Project Member Reported by yhirano@chromium.org, May 14 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d

commit bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Jun 07 13:31:24 2018

Introduce Request.isHistoryNavigation

Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5MSY_oNVEjo

Bug:  842551 
Change-Id: I41a76d14f449ae351f82ca3566ba8358178bad09
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1077908
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565249}
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/content/common/service_worker/service_worker_fetch_request_mojom_traits.cc
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/content/common/service_worker/service_worker_fetch_request_mojom_traits.h
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/content/common/service_worker/service_worker_types.proto
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/external/wpt/fetch/api/idl.any-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/external/wpt/fetch/api/idl.any.sharedworker-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/external/wpt/fetch/api/idl.any.worker-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/external/wpt/fetch/api/idl.https.any.serviceworker-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-reset-attributes.https-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-structure-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-keys-attributes-for-service-worker.https-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/blink/public/platform/modules/fetch/fetch_api_request.mojom
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/blink/public/platform/modules/serviceworker/web_service_worker_request.h
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/blink/renderer/core/fetch/fetch_request_data.cc
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/blink/renderer/core/fetch/fetch_request_data.h
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/blink/renderer/core/fetch/request.cc
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/blink/renderer/core/fetch/request.h
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/blink/renderer/core/fetch/request.idl
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/blink/renderer/platform/exported/web_service_worker_request.cc
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/blink/renderer/platform/mojo/fetch_api_request_struct_traits.cc
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/blink/renderer/platform/mojo/fetch_api_request_struct_traits.h
[modify] https://crrev.com/bbc4c3c6cd30d1a25f6bdaef5927bc21aa9f6d9d/third_party/blink/renderer/platform/runtime_enabled_features.json5

Blocking: 850825
This is shipping in Chrome 69, right?
Yes, but we have a TODO related to Cache API.
Blockedon: 847357
Labels: M-69
Status: Fixed (was: Assigned)
This shipped in M69. The remaining work about Cache Storage API is tracked in issue 847357.

Sign in to add a comment