Issue metadata
Sign in to add a comment
|
Null-dereference READ in CommonNameMismatchHandler::OnSimpleLoaderResponseStarted |
||||||||||||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5672305049731072 Fuzzer: meacer_web_ext Job Type: linux_asan_chrome_mp Platform Id: linux Crash Type: Null-dereference READ Crash Address: 0x000000000010 Crash State: CommonNameMismatchHandler::OnSimpleLoaderResponseStarted base::internal::Invoker<base::internal::BindState<void network::SaveToStringBodyHandler::NotifyConsumerOfCompletion Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=557248:557251 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5672305049731072 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
May 14 2018
pilgrim: Seems legit mmenke: Adding for an extra set of eyes - does the SimpleURLLoader follow a different API contract than the URLFetcher regarding shutdown semantics and callbacks? This has the hallmark of using a callback after deletion, which, given the base::Unretained(), seems possible - but it'd also seem like we only got here on an errant PostTask, which the URLFetcher API seemed to avoid?
,
May 14 2018
,
May 14 2018
Deleting a SimpleURLLoader should cancel the request, and prevent all callbacks from being invoked. Just looking at the code itself, I think the issue is most likely that response_head is nullptr, so CommonNameMismatchHandler::OnSimpleLoaderComplete() is passing in a nullptr as a const-ref.
,
May 14 2018
D'oh, you're totally right. I was reading the 0x10 as the DCHECK(sequence_checker_), totally missing that the line number indicates it's when accessing response_head
,
May 14 2018
on it
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e6a1ff73ee461ce5809d1d2f80b307cbdcc163b commit 7e6a1ff73ee461ce5809d1d2f80b307cbdcc163b Author: Mark Pilgrim <pilgrim@chromium.org> Date: Mon May 14 17:34:13 2018 Refactor CommonNameMismatchHandler to check null response head Bug: 842484 Test: CommonNameMismatchBrowserTest.NoCrashIfBothSubdomainsHaveCommonNameErrors Change-Id: I6551dfbc129a544e449040c12a30236c6a57efe8 Reviewed-on: https://chromium-review.googlesource.com/1057417 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#558365} [modify] https://crrev.com/7e6a1ff73ee461ce5809d1d2f80b307cbdcc163b/chrome/browser/ssl/common_name_mismatch_handler.cc [modify] https://crrev.com/7e6a1ff73ee461ce5809d1d2f80b307cbdcc163b/chrome/browser/ssl/common_name_mismatch_handler.h [modify] https://crrev.com/7e6a1ff73ee461ce5809d1d2f80b307cbdcc163b/chrome/browser/ssl/ssl_browsertest.cc
,
May 14 2018
,
May 14 2018
Automatically applying components based on crash stacktrace and information from OWNERS files. If this is incorrect, please apply the Test-Predator-Wrong-Components label.
,
May 14 2018
,
May 15 2018
ClusterFuzz testcase 6537422192771072 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
May 15 2018
ClusterFuzz has detected this issue as fixed in range 558364:558366. Detailed report: https://clusterfuzz.com/testcase?key=5672305049731072 Fuzzer: meacer_web_ext Job Type: linux_asan_chrome_mp Platform Id: linux Crash Type: Null-dereference READ Crash Address: 0x000000000010 Crash State: CommonNameMismatchHandler::OnSimpleLoaderResponseStarted base::internal::Invoker<base::internal::BindState<void network::SaveToStringBodyHandler::NotifyConsumerOfCompletion Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=557248:557251 Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=558364:558366 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5672305049731072 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by brajkumar@chromium.org
, May 14 2018Components: Internals>Network
Labels: -Type-Bug M-68 Test-Predator-Wrong Type-Bug-Regression
Owner: pilgrim@chromium.org
Status: Assigned (was: Untriaged)