New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842476 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Crostini frame title rendering incorrect

Project Member Reported by reve...@chromium.org, May 12 2018

Issue description

Chrome shouldn't be showing the title of crostini windows by default. The title should only be shown in overview mode, window switcher etc.
 
This is a regression since https://chromium-review.googlesource.com/c/chromium/src/+/1050799 landed.

Comment 2 by est...@chromium.org, May 14 2018

Status: Started (was: Assigned)
will look at this today. Thanks for report.
Labels: Hotlist-Crostini-UI

Comment 4 by mukai@chromium.org, May 14 2018

Cc: shihuis@chromium.org skuhne@chromium.org mukai@chromium.org ajha@chromium.org brajkumar@chromium.org osh...@chromium.org
 Issue 841719  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5052c19bd41059cf0cfc206f8af218a164a9df01

commit 5052c19bd41059cf0cfc206f8af218a164a9df01
Author: Evan Stade <estade@chromium.org>
Date: Mon May 21 22:16:11 2018

Chrome OS - Don't show window title in container windows.

This restores the behavior that the window title won't be shown
in the window frame for container windows (ARC++/Crostini). The
exception is when a debug title ("extra title") has been set, in
which case the debug string is shown.

Overview mode will use the normal title, unless a debug/"extra" title
is set, in which case it uses that.

Bug:  842476 
Change-Id: Id0df3466b66e769363f313772bf63ff9f26e7b80
Reviewed-on: https://chromium-review.googlesource.com/1058560
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560373}
[modify] https://crrev.com/5052c19bd41059cf0cfc206f8af218a164a9df01/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/5052c19bd41059cf0cfc206f8af218a164a9df01/ash/frame/custom_frame_view_ash.h
[modify] https://crrev.com/5052c19bd41059cf0cfc206f8af218a164a9df01/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/5052c19bd41059cf0cfc206f8af218a164a9df01/components/exo/client_controlled_shell_surface_unittest.cc
[modify] https://crrev.com/5052c19bd41059cf0cfc206f8af218a164a9df01/components/exo/shell_surface_base.cc
[modify] https://crrev.com/5052c19bd41059cf0cfc206f8af218a164a9df01/components/exo/shell_surface_base.h
[modify] https://crrev.com/5052c19bd41059cf0cfc206f8af218a164a9df01/components/exo/shell_surface_unittest.cc

Comment 6 by est...@chromium.org, May 22 2018

Status: Fixed (was: Started)
fixed for crostini. For ARC++ apps in debug mode, I'm re-opening 841719

Comment 7 by vapier@chromium.org, Jun 21 2018

Components: OS>Systems>Containers

Sign in to add a comment