New issue
Advanced search Search tips

Issue 842463 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: May 2018
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Border radius not applying on div around an image with overflow hidden and inline-block.

Reported by d...@mcmill.co.uk, May 12 2018 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3428.0 Safari/537.36

Steps to reproduce the problem:
1. Go to https://codepen.io/anon/pen/xjzbeR on firefox, see it is rounded into a circle.
2. Go there on chrome canary and see it is a square.

What is the expected behavior?
It is rounded into a circle

What went wrong?
It doesn't apply the border radius and stays a square.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 68.0.3428.0  Channel: canary
OS Version: OS X 10.12.6
Flash Version: 

This bug has caused profile pictures on both Messenger.com and youtube to become squares.

Comment 1 by chrishtr@chromium.org, May 12 2018

Components: -Blink>CSS Blink>Paint

Comment 2 by krajshree@chromium.org, May 14 2018

Labels: Needs-Triage-M68

Comment 3 by krajshree@chromium.org, May 14 2018

Labels: Needs-Bisect

Comment 4 by schenney@chromium.org, May 14 2018

Labels: -Type-Bug -Pri-2 -Needs-Bisect -Needs-Triage-M68 M-68 ReleaseBlock-Beta FoundIn-68 Target-68 Pri-1 Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Bisects to

https://chromium.googlesource.com/chromium/src/+/8f50572b9c4d946b67178cc66bed5ac481084469

[SPv175+] Revert "Don't output OverflowClip if InnerBorderRadiusClip already has the same rect"
Project Member

Comment 5 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2cfcd78b0b762eea5eaffec65ed2f217e179403

commit e2cfcd78b0b762eea5eaffec65ed2f217e179403
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Mon May 14 23:38:49 2018

[PE] Fix border-radius with overflow-clip without visual overflow

We still omit OverflowClip when there is no visual overflow, but we
need to apply the inner border radius clip when clipping a box.

Bug:  842463 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I19937a58b99cc91f70591041782cf9dc26f1a55b
Reviewed-on: https://chromium-review.googlesource.com/1057838
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558529}
[modify] https://crrev.com/e2cfcd78b0b762eea5eaffec65ed2f217e179403/third_party/WebKit/LayoutTests/paint/background/rounded-clip-fractional-offset-expected.png
[modify] https://crrev.com/e2cfcd78b0b762eea5eaffec65ed2f217e179403/third_party/WebKit/LayoutTests/platform/linux/fast/clip/overflow-border-radius-clip-expected.png
[modify] https://crrev.com/e2cfcd78b0b762eea5eaffec65ed2f217e179403/third_party/WebKit/LayoutTests/platform/linux/fast/clip/overflow-border-radius-combinations-expected.png
[delete] https://crrev.com/1f552ddb3033a95fec6ef56c4cc2ffb598c1234e/third_party/WebKit/LayoutTests/platform/linux/fast/clip/overflow-border-radius-combinations-expected.txt
[modify] https://crrev.com/e2cfcd78b0b762eea5eaffec65ed2f217e179403/third_party/WebKit/LayoutTests/platform/linux/fast/layers/overflow-hidden-rounded-corners-occlusion-expected.png
[modify] https://crrev.com/e2cfcd78b0b762eea5eaffec65ed2f217e179403/third_party/WebKit/LayoutTests/platform/mac/fast/clip/overflow-border-radius-clip-expected.png
[modify] https://crrev.com/e2cfcd78b0b762eea5eaffec65ed2f217e179403/third_party/WebKit/LayoutTests/platform/mac/fast/clip/overflow-border-radius-combinations-expected.png
[modify] https://crrev.com/e2cfcd78b0b762eea5eaffec65ed2f217e179403/third_party/WebKit/LayoutTests/platform/mac/fast/layers/overflow-hidden-rounded-corners-occlusion-expected.png
[modify] https://crrev.com/e2cfcd78b0b762eea5eaffec65ed2f217e179403/third_party/WebKit/LayoutTests/platform/win/fast/clip/overflow-border-radius-clip-expected.png
[modify] https://crrev.com/e2cfcd78b0b762eea5eaffec65ed2f217e179403/third_party/WebKit/LayoutTests/platform/win/fast/clip/overflow-border-radius-combinations-expected.png
[modify] https://crrev.com/e2cfcd78b0b762eea5eaffec65ed2f217e179403/third_party/WebKit/LayoutTests/platform/win/fast/layers/overflow-hidden-rounded-corners-occlusion-expected.png
[modify] https://crrev.com/e2cfcd78b0b762eea5eaffec65ed2f217e179403/third_party/blink/renderer/core/paint/box_clipper_base.cc

Comment 6 by wangxianzhu@chromium.org, May 14 2018

Status: Fixed (was: Assigned)
Sorry for my carelessness. Should have noticed the break when the original CL was landing. Thanks for the report.
►

Sign in to add a comment