New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 842462 link

Starred by 1 user
Status: WontFix
Owner:
ayatane@chromium.org
Closed: May 2018
Cc:
█ ntang@chromium.org
█ mattmallett@chromium.org
pprabhu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Lucifer should throw AutoservRunError in the event tko parse throws exception

Project Member Reported by haddowk@chromium.org, May 12 2018 

Related to the problems experienced in crbug/842451 the suite should throw an autoserv error if the tko parse crashes,

this would allow this test to fail here in the cq

https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/server/site_tests/moblab_RunSuite/moblab_RunSuite.py?rcl=8c605420ea73877f7473bbe896bdd8fb54e166f7&l=81

Comment 1 by ayatane@chromium.org, May 14 2018 

This isn't really relevant to Lucifer.  The host class always raises the misnamed autoserv error if the command exits non-zero.  In this case the command appears to be run_suite.py.  Basically everything that would cause a CQ suite to fail should also cause this moblab_RunSuite command to fail.

Based on the logs, tko parse didn't crash, or at least is suppressing its own error.  If tko parse exited non-zero, lucifer_run_job and job_reporter would also have exited non-zero, and the logs would have included a message "Error running job: ..."

Comment 2 by haddowk@chromium.org, May 15 2018

Status: WontFix (was: Assigned)
Thanks for the info I looked at parse.py and no easy way to stop it eating its own exceptions.

I will file a bug for myself to add to the moblab test that the job.serialize should be produced for a test to be "successful"
►

Sign in to add a comment