Some years ago I disabled the call to CountryCodeForCurrentTimezone() from PersonalDataManager::GetDefaultCountryCodeForNewAddress() in components/autofill/core/browser/personal_data_manager.cc for Vivaldi's code.

The reason at the time was that the function returned highly incorrect country codes, such as Hungary instead of Norway. This also caused at least one unit test to fail.

While checking old patches in our v67 code base, I checked the result of this function again, and found that it seemed to return the correct country code, at least for my location, based on the timezone (CET), and the old failing test case was no longer present, so I decided to remove our patch.

However, when running tests, a lot of tests started failing, most of them *crashes*:

PaymentRequestShippingAddressEditorTest.NoCountryNoState
PaymentRequestShippingAddressEditorTest.NoCountryValidState_AsyncRegionLoad
PaymentRequestShippingAddressEditorTest.SyncData
PaymentRequestShippingAddressEditorTest.AddImpossiblePhoneNumber
PaymentRequestShippingAddressEditorTest.AsyncData
PaymentRequestShippingAddressEditorTest.DefaultRegion_RegionCode
PaymentRequestShippingAddressEditorTest.NoCountryInvalidState
PaymentRequestShippingAddressEditorTest.NoCountryValidState_SyncRegionLoad
PaymentRequestShippingAddressEditorTest.SyncDataInIncognito
PaymentRequestShippingAddressEditorTest.AddPossiblePhoneNumber
PaymentRequestShippingAddressEditorTest.TimingOutRegionData
PaymentRequestShippingAddressEditorTest.AddInternationalPhoneNumberFromOtherCountry
PaymentRequestShippingAddressEditorTest.DefaultRegion_RegionName
PaymentRequestShippingAddressEditorTest.FailToLoadRegionData
PaymentRequestCreditCardEditorTest.CreateNewBillingAddress

The reason for the problem seems to be that the tests require a US country location, and will fail if they are run in other countries (I have tested with NO and GB returned from the function, and our testers run mostly on Iceland, some in Norway). BTW, I have noticed a tendency in other tests to require US specific keyboards, time and date formats, and other similar country or language specific requirements.

While this might only be a problem for the browser_tests, the fact that the crashes was in a call to combobox->model()->GetItemAt() (I have not checked, but either combobox or model is likely NULL) makes me concerned that this could be causing crashers during normal form autofill usage, as well.

I would recommend running unit tests in environments for multiple languages, keyboards, and countries, as well as time zones.