Defer to Android system DNS resolver when Private DNS is active |
||||||
Issue descriptionCurrently, Chromium can use the async resolver when Private DNS is active on Android. As we've discussed, now that isPrivateDnsActive() is finalized [1], Chromium should check it and not emit unencrypted queries if it is true. [1] https://developer.android.com/reference/android/net/LinkProperties.html#isPrivateDnsActive()
,
May 18 2018
I started https://chromium-review.googlesource.com/c/chromium/src/+/1065463 to address this.
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43b695ff7d62a9e8f0b8d14c543cc6a4e746fd43 commit 43b695ff7d62a9e8f0b8d14c543cc6a4e746fd43 Author: Paul Jensen <pauljensen@chromium.org> Date: Tue May 29 21:04:05 2018 Disable internal DNS resolver when Android P using private DNS Bug: 842456 Change-Id: I8f0c17cd50c75987c051e62344ac5e907e1b1133 Reviewed-on: https://chromium-review.googlesource.com/1065463 Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562584} [modify] https://crrev.com/43b695ff7d62a9e8f0b8d14c543cc6a4e746fd43/net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java [modify] https://crrev.com/43b695ff7d62a9e8f0b8d14c543cc6a4e746fd43/net/android/network_library.cc [modify] https://crrev.com/43b695ff7d62a9e8f0b8d14c543cc6a4e746fd43/net/android/network_library.h [modify] https://crrev.com/43b695ff7d62a9e8f0b8d14c543cc6a4e746fd43/net/dns/dns_config_service_posix.cc [modify] https://crrev.com/43b695ff7d62a9e8f0b8d14c543cc6a4e746fd43/net/dns/dns_config_service_posix.h
,
May 30 2018
,
May 30 2018
Actually maybe this should get merged to M68
,
May 31 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 4 2018
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccff333c24a74342b799d71216d468128ebed01d commit ccff333c24a74342b799d71216d468128ebed01d Author: Paul Jensen <pauljensen@chromium.org> Date: Mon Jun 04 12:53:46 2018 Disable internal DNS resolver when Android P using private DNS Bug: 842456 Change-Id: I8f0c17cd50c75987c051e62344ac5e907e1b1133 Reviewed-on: https://chromium-review.googlesource.com/1065463 Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562584}(cherry picked from commit 43b695ff7d62a9e8f0b8d14c543cc6a4e746fd43) Reviewed-on: https://chromium-review.googlesource.com/1084947 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#129} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/ccff333c24a74342b799d71216d468128ebed01d/net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java [modify] https://crrev.com/ccff333c24a74342b799d71216d468128ebed01d/net/android/network_library.cc [modify] https://crrev.com/ccff333c24a74342b799d71216d468128ebed01d/net/android/network_library.h [modify] https://crrev.com/ccff333c24a74342b799d71216d468128ebed01d/net/dns/dns_config_service_posix.cc [modify] https://crrev.com/ccff333c24a74342b799d71216d468128ebed01d/net/dns/dns_config_service_posix.h |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mge...@chromium.org
, May 14 2018Owner: lassey@chromium.org