New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842451 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

TKO Parrser crashing on moblab

Project Member Reported by haddowk@chromium.org, May 12 2018

Issue description


Observed in the lastest run on the CQ, full log attached.

tko parser: Error parsing leaf path: /usr/local/autotest/results/3-moblab/192.168.231.103
Exception:
Unexpected type <type 'int'> for attr afe_parent_job_id, should be <type 'str'>
Traceback (most recent call last):
  File "/usr/local/autotest/tko/parse.py", line 635, in parse_leaf_path
    parse_options)
  File "/usr/local/autotest/tko/db.py", line 164, in run_with_retry
    result = function(*args, **dargs)
  File "/usr/local/autotest/tko/parse.py", line 452, in parse_one
    export_tko_job_to_file(job, jobname, binary_file_name)
  File "/usr/local/autotest/tko/parse.py", line 301, in export_tko_job_to_file
    serializer.serialize_to_binary(job, jobname, filename)
  File "/usr/local/autotest/tko/job_serializer.py", line 114, in serialize_to_binary
    self.set_pb_job(the_job, pb_job, tag)
  File "/usr/local/autotest/tko/job_serializer.py", line 187, in set_pb_job
    self.set_trivial_attr(tko_job, pb_job, self.job_type_dict)
  File "/usr/local/autotest/tko/job_serializer.py", line 418, in set_trivial_attr
    self.set_attr_safely(pb_obj, attr, value, attr_type)
  File "/usr/local/autotest/tko/job_serializer.py", line 444, in set_attr_safely
    (type(value), attr, vartype))
AssertionError: Unexpected type <type 'int'> for attr afe_parent_job_id, should be <type 'str'>
 
job_reporter_output.log
11.7 KB View Download
Cc: ntang@chromium.org stephenlin@chromium.org
 Issue 842009  has been merged into this issue.
Owner: haddowk@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1c58ad7041ed8f3630828709d516d608ea31138d

commit 1c58ad7041ed8f3630828709d516d608ea31138d
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue May 15 17:57:03 2018

[autotest] Fix type error for afe_parent_job_id

cl/1043089 changed the type of afe_parent_job_id from string to int

To keep the proto backward compatible, change the assert that the
tko model type does not match the proto type to a warning and add
an explicit casti from tko model to the proto.

BUG= chromium:842451 
TEST=moblab tryjob, unittests, build and testing on moblab.

Change-Id: I62f583785a5b8b001d623b1a104043a50cf9f67b
Reviewed-on: https://chromium-review.googlesource.com/1058439
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/1c58ad7041ed8f3630828709d516d608ea31138d/tko/job_serializer.py
[modify] https://crrev.com/1c58ad7041ed8f3630828709d516d608ea31138d/tko/job_serializer_unittest.py

Status: Fixed (was: Started)

Sign in to add a comment