New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842428 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Flaky-Test: SnooperNodeTest.HandlesMissingInput/1


Participants' hotlists:
AudioService-FixIt


Sign in to add a comment

SnooperNodeTest.HandlesMissingInput/1 is Flaky

Project Member Reported by Findit, May 12 2018

Issue description

Findit has detected a flake at test SnooperNodeTest.HandlesMissingInput/1.

Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I69f5c358ba55fa997e1c3859d653638131f1394c
Regression range: None

Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVypAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJuY2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKGRiZykoMSkvNjg5ODUvc2VydmljZXNfdW5pdHRlc3RzL1UyNXZiM0JsY2s1dlpHVlVaWE4wTGtoaGJtUnNaWE5OYVhOemFXNW5TVzV3ZFhRdk1RPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

If this result was incorrect, apply the label Test-Findit-Wrong, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
 
Project Member

Comment 1 by Findit, May 12 2018

Findit identified the culprit r557949 with confidence 70.0% in the config "chromium.win / Win7 Tests (dbg)(1)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVypAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJuY2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKGRiZykoMSkvNjg5ODUvc2VydmljZXNfdW5pdHRlc3RzL1UyNXZiM0JsY2s1dlpHVlVaWE4wTGtoaGJtUnNaWE5OYVhOemFXNW5TVzV3ZFhRdk1RPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Comment 2 by hbos@chromium.org, May 14 2018

Labels: -Sheriff-Chromium
Owner: finnur@chromium.org
Please take a look finnur@, is this related to your change as Findit suspects?

Comment 3 by hbos@chromium.org, May 14 2018

Status: Assigned (was: Available)

Comment 4 by finnur@chromium.org, May 14 2018

Cc: camurcu@google.com
Components: Tools>Test>FindIt>Flakiness
Labels: Test-Findit-Wrong OS-Windows
Owner: ----
Status: Untriaged (was: Assigned)
No, I don't think so. I don't see how my change could cause a timeout in an input handling unit test. 

But there's another CL in the same build that is changing input handling...
https://chromium-review.googlesource.com/c/chromium/src/+/1048246
Unfortunately, I can't assign the bug to that person, so I'll leave it as unsigned, as specified above.
From logs:

[1953/1955] SnooperNodeTest.HandlesMissingInput/1 (TIMED OUT)
[1954/1955] SnooperNodeTest.HandlesMissingInput/2 (41993 ms)
[1955/1955] SnooperNodeTest.HandlesMissingInput/3 (3497 ms)
Retrying 1 test (retry #1)
Still waiting for the following processes to finish:
	".\services_unittests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_flagfile="C:\Users\chrome-bot\AppData\Local\Temp\scoped_dir3808_25737\a32487ab-e6c1-4176-a0e9-502f360131c4.tmp" --single-process-tests --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\3808_22015\test_results.xml" --test-launcher-summary-output="e:\b\s\w\iohf475g\output.json"
Still waiting for the following processes to finish:
	".\services_unittests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_flagfile="C:\Users\chrome-bot\AppData\Local\Temp\scoped_dir3808_25737\a32487ab-e6c1-4176-a0e9-502f360131c4.tmp" --single-process-tests --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\3808_22015\test_results.xml" --test-launcher-summary-output="e:\b\s\w\iohf475g\output.json"




Comment 5 Deleted

Comment 6 by camurcu@google.com, May 14 2018

It seems like an audio input test. I don't see how my cl would affect it.

Comment 7 by sadrul@chromium.org, May 14 2018

Cc: m...@chromium.org olka@chromium.org
/cc+ miu@, who landed a CL related to SnooperNode recently (crrev.com/557349).
/cc+ olka@ as audio owner.

Comment 8 by m...@chromium.org, May 14 2018

I am OOO today. If this is the debug bot, we can just disable the test using !NDEBUG for now. I have no idea how these tests have been so temperamental on win dbg only. I can never repro on my local machine.

Comment 9 by m...@chromium.org, May 15 2018

Components: Internals>Media>ScreenCapture
Owner: m...@chromium.org
Status: Assigned (was: Untriaged)

Comment 10 by m...@chromium.org, May 15 2018

Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3071ee7b3fbff93eb57f6e92bc77ff70f836a4f4

commit 3071ee7b3fbff93eb57f6e92bc77ff70f836a4f4
Author: Yuri Wiitala <miu@chromium.org>
Date: Tue May 15 23:29:17 2018

Disable SnooperNodeTest.HandlesMissingInput for debug builds.

Unexpectedly, the test seems to randomly time out on Win dbg bots only.
Disable the test for debug builds, with a TODO to root-cause/revisit to
fix and re-enable.

TBR=olka@chromium.org

Bug: 842428
Change-Id: I8524c31247f452675e6c91d4ac5c3fc471a9525e
Reviewed-on: https://chromium-review.googlesource.com/1059858
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558880}
[modify] https://crrev.com/3071ee7b3fbff93eb57f6e92bc77ff70f836a4f4/services/audio/snooper_node_unittest.cc

Labels: -Pri-1 Pri-3
Labels: -Pri-3 Test-Disabled M-72 Pri-2

Sign in to add a comment