Sometimes the bindings generator produces include lines that look like so:
#include "../../../out/Debug/gen/third_party/blink/renderer/core/window_core_constructors.h"
(After https://chromium-review.googlesource.com/c/1054523/ , the v8 bindings generator is the only script with this behavior: https://cs.chromium.org/search/?q=%23include.*out%5C/debug&type=cs)
This is bad since this will usually be different on different machines and so goma's cache works less well.
It looks like just saying
#include "third_party/blink/renderer/core/window_core_constructors.h"
should have the same effect in practice (even though it admittedly looks confusing). Maybe the bindings should be compiled with the build dir root as -I flag and then the line could e.g. be
#include "gen/third_party/blink/renderer/core/window_core_constructors.h"
which makes it more clear that the header is generated.
Comment 1 by tkent@chromium.org
, May 14 2018