New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842404 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Omnibox] remove color styling (that the old answers have)

Project Member Reported by dschuyler@chromium.org, May 12 2018

Issue description

The answers have colorful descriptions, the new style doesn't show the style variations.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf4c0b1f175648c2dbdd57c5dc86c4ed51fd6392

commit cf4c0b1f175648c2dbdd57c5dc86c4ed51fd6392
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue May 15 01:50:24 2018

[Omnibox] remove color styling (that the old answers have)

The answers have colorful descriptions, the new style doesn't show the style
variations.

Bug:  842404 
Change-Id: I8fbbd7ba4593a39a7eed38294773b8ba24592f3f
Reviewed-on: https://chromium-review.googlesource.com/1056035
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558580}
[modify] https://crrev.com/cf4c0b1f175648c2dbdd57c5dc86c4ed51fd6392/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
[modify] https://crrev.com/cf4c0b1f175648c2dbdd57c5dc86c4ed51fd6392/chrome/browser/ui/views/omnibox/omnibox_text_view.cc

Status: Fixed (was: Started)
Labels: Needs-Feedback
Tried checking the issue on latest chrome version 68.0.3432.0 using Mac 10.13.1, Ubuntu 14.04 and Windows 10 by searching any random word. We didn't observe any change/variation in the results of that search on chrome version 68.0.3432.0 and versions prior to this(i.e., the versions without fix).

@Dave Schuyler: As we are not very sure about the expected and actual behaviour, could you please let us know those behaviours and help us in verifying the fix.

Thanks!

Comment 4 Deleted

Whoops, I shouldn't say "disable" on line 1. I should say with/without the fix.

#3 sorry: 

Without the fix:

1. in about:flags enable #omnibox-new-answer-layout
2. Search for something like "weather in los angeles" or "appl stock price". These will show an Answer in Suggest (AiS)
3. one of the items in the dropdown list will be an AiS element with a styled text in the second line

With the fix:

On step 3 the styled text should no longer get fancy styling.

Sign in to add a comment