New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842399 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 838733



Sign in to add a comment

[Rich Entity Suggest] round corners of images

Project Member Reported by dschuyler@chromium.org, May 12 2018

Issue description

Make the images a roundrect with a corner radius of 4.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c72cef375c3853bda40bcb45238e16550262e18

commit 6c72cef375c3853bda40bcb45238e16550262e18
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue May 15 03:24:10 2018

[Omnibox] Round corners of Rich Suggestions

This CL rounds the corners of Rich images with a roundRect clip path.

Bug:  842399 
Change-Id: I057d9cabcc46a71efc64145e6b90041e6d1067be
Reviewed-on: https://chromium-review.googlesource.com/1056397
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558599}
[modify] https://crrev.com/6c72cef375c3853bda40bcb45238e16550262e18/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc

Status: Fixed (was: Started)
Labels: Needs-Feedback
Unable to reproduce the issue with below steps.

1. Enabled "Omnibox rich entity suggestions" flag from chrome://flags.
2. Typed temperature in omnibox and didn't find any difference in build without fix and build with fix.

@dschuyler: Please check the steps and let us know if we miss anything. Please help in verifying the issue.

Thanks!

842399_68.0.3432.0.png
142 KB View Download
842399_build without fix.png
131 KB View Download
1. in about:flags enable #omnibox-rich-entity-suggestions
2. in omnibox, search for a common name like "chris"
3. one or more entity suggestions (with images) should appear in the drop down

before the fix the image often had square corners; after the fix they should all have rounded corners.

Sign in to add a comment