New issue
Advanced search Search tips

Issue 842395 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Window bounds in split screen is corrupted after device rotation

Project Member Reported by mkarkada@chromium.org, May 12 2018

Issue description

Chrome OS: 10575.32.0, 67.0.3396.41 dev channel on eve, caroline devices

What steps will reproduce the problem?

Scenario 1:
1. Open browser window in tablet mode (landscape view) and enter overview. 
2. Drag and snap this window to view in split screen.
3. Rotate the device to portrait mode.

What happens instead?
Window bounds in split screen is corrupted.
 
Screenshot 2018-05-11 at 15.22.24.png
2.1 MB View Download
Owner: omrilio@chromium.org
omrilio@ please triage
Status: Assigned (was: Untriaged)

Comment 3 by x...@chromium.org, May 16 2018

Owner: sammiequon@chromium.org
Also another one. I think it used to work.
Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3

commit 2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3
Author: Sammie Quon <sammiequon@google.com>
Date: Thu May 17 15:41:51 2018

overview: Shield widget bounds now correct after rotation.

Shield widget gets updated in PositionWindows, which has an early out if
no windows. Move update before early return.

Also fix a big with the no recents message not disappearing if an window
item is added back to the grid via split view.

Test: manual
Bug:  842395 ,  842394 
Change-Id: I52dcdf9c012edc32c7d47bbdd978b6f59376a289
Reviewed-on: https://chromium-review.googlesource.com/1063171
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559545}
[modify] https://crrev.com/2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3/ash/wm/overview/window_selector.h

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Issue is fixed on M68 (10718.34.0, 68.0.3440.40) but still exist on M67 build (10575.58.0, 67.0.3396.99). Can the fix be merged to stable?
Cc: omrilio@chromium.org
+omrilio

This is a rare edge case, and M67 is not a special build AFAICT, so a merge is not necessary. omrilio@, please reassign this to me if you want it in M67.
Status: Fixed (was: Assigned)

Sign in to add a comment