New issue
Advanced search Search tips

Issue 842394 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Window bounds in overview are corrupted after device rotation

Project Member Reported by mkarkada@chromium.org, May 12 2018

Issue description

Chrome OS: 10575.32.0, 67.0.3396.41 dev channel on eve, caroline devices

What steps will reproduce the problem?
1. Open browser window in tablet portrait mode and enter overview. 
2. Drag and snap this window to view in split screen.
3. Minimize this window and the browser window falls to overview.
4. Rotate the device to landscape view.

What happens instead?
Window bounds are corrupted in overview.
 
Screenshot 2018-05-11 at 15.02.25.png
2.3 MB View Download
IMG-2802.JPG
2.1 MB View Download
Owner: omrilio@chromium.org
Status: Assigned (was: Untriaged)
omrilio@ please triage

Comment 2 by x...@chromium.org, May 16 2018

Owner: sammiequon@chromium.org
Sammie, can you take a look? 
Cc: osh...@chromium.org
+oshima

I think minimized windows always did not resize properly on rotation. But now there are artifacts instead of all black.

oshima any ideas?
Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3

commit 2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3
Author: Sammie Quon <sammiequon@google.com>
Date: Thu May 17 15:41:51 2018

overview: Shield widget bounds now correct after rotation.

Shield widget gets updated in PositionWindows, which has an early out if
no windows. Move update before early return.

Also fix a big with the no recents message not disappearing if an window
item is added back to the grid via split view.

Test: manual
Bug:  842395 ,  842394 
Change-Id: I52dcdf9c012edc32c7d47bbdd978b6f59376a289
Reviewed-on: https://chromium-review.googlesource.com/1063171
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559545}
[modify] https://crrev.com/2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3/ash/wm/overview/window_selector.h

whoops

#4 - does not actually fix the bug, but it does remove the "No recents" label which should not be shown in this case.

Comment 6 by osh...@chromium.org, May 17 2018

Re #3, not sure why, but it does get resized properly but gets corrupted sometimes. It's using mirror view so i'd check if something has changed
or check if it's gets properly mirrored.
Status: Fixed (was: Assigned)
Labels: M-68 M-69
Status: Assigned (was: Fixed)
Issue still not fixed, the window disappears after minimizing in split view instead of falling back to overview. Even 'No recent items' message vanishes.
Tested on M69 (10836.0.0, 69.0.3479.0).

Where as original issue still exist on M67 & M68.
I did the exact steps and I don't see any artifacts. The message is rightfully gone.
Status: Fixed (was: Assigned)
Closing as per comment #10

Sign in to add a comment