Issue metadata
Sign in to add a comment
|
Window bounds in overview are corrupted after device rotation |
||||||||||||||||||||||
Issue descriptionChrome OS: 10575.32.0, 67.0.3396.41 dev channel on eve, caroline devices What steps will reproduce the problem? 1. Open browser window in tablet portrait mode and enter overview. 2. Drag and snap this window to view in split screen. 3. Minimize this window and the browser window falls to overview. 4. Rotate the device to landscape view. What happens instead? Window bounds are corrupted in overview.
,
May 16 2018
Sammie, can you take a look?
,
May 17 2018
+oshima I think minimized windows always did not resize properly on rotation. But now there are artifacts instead of all black. oshima any ideas?
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3 commit 2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3 Author: Sammie Quon <sammiequon@google.com> Date: Thu May 17 15:41:51 2018 overview: Shield widget bounds now correct after rotation. Shield widget gets updated in PositionWindows, which has an early out if no windows. Move update before early return. Also fix a big with the no recents message not disappearing if an window item is added back to the grid via split view. Test: manual Bug: 842395 , 842394 Change-Id: I52dcdf9c012edc32c7d47bbdd978b6f59376a289 Reviewed-on: https://chromium-review.googlesource.com/1063171 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#559545} [modify] https://crrev.com/2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3/ash/wm/overview/window_grid.cc [modify] https://crrev.com/2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3/ash/wm/overview/window_selector.cc [modify] https://crrev.com/2a92c1111bdaf14ac61c4d2cf6f6d3723449acf3/ash/wm/overview/window_selector.h
,
May 17 2018
whoops #4 - does not actually fix the bug, but it does remove the "No recents" label which should not be shown in this case.
,
May 17 2018
Re #3, not sure why, but it does get resized properly but gets corrupted sometimes. It's using mirror view so i'd check if something has changed or check if it's gets properly mirrored.
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9929f29f00807cb472b72080a71399bf8379e54e commit 9929f29f00807cb472b72080a71399bf8379e54e Author: Sammie Quon <sammiequon@google.com> Date: Wed Jun 20 23:54:01 2018 overview: Fix corrupt minimized mirror views after rotation. Test: manual Bug: 842394 Change-Id: Iaf1bb8bb94da5b6d2e60009a21b02bde894f1326 Reviewed-on: https://chromium-review.googlesource.com/1105196 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#569092} [modify] https://crrev.com/9929f29f00807cb472b72080a71399bf8379e54e/ash/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/9929f29f00807cb472b72080a71399bf8379e54e/ash/wm/overview/scoped_transform_overview_window.h [modify] https://crrev.com/9929f29f00807cb472b72080a71399bf8379e54e/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/9929f29f00807cb472b72080a71399bf8379e54e/ash/wm/overview/window_selector_item.h [modify] https://crrev.com/9929f29f00807cb472b72080a71399bf8379e54e/ash/wm/window_mirror_view.cc [modify] https://crrev.com/9929f29f00807cb472b72080a71399bf8379e54e/ash/wm/window_mirror_view.h
,
Jun 21 2018
,
Jul 2
Issue still not fixed, the window disappears after minimizing in split view instead of falling back to overview. Even 'No recent items' message vanishes. Tested on M69 (10836.0.0, 69.0.3479.0). Where as original issue still exist on M67 & M68.
,
Jul 2
I did the exact steps and I don't see any artifacts. The message is rightfully gone.
,
Aug 8
Closing as per comment #10 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ovanieva@chromium.org
, May 16 2018Status: Assigned (was: Untriaged)