New issue
Advanced search Search tips

Issue 842387 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 842296



Sign in to add a comment

Use allowlist/blocklist in extensions features code

Project Member Reported by rdevlin....@chromium.org, May 12 2018

Issue description

We should update the features terminology as part of issue 842296.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66536a464fc7894f18a3d93ab52a7124190144cc

commit 66536a464fc7894f18a3d93ab52a7124190144cc
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu May 17 22:49:46 2018

[Extensions] Use allowlist/blocklist in extensions features C++ files

A follow-up will update all the .json files.

Bug: 842387
Change-Id: Ic242c2dbda231dc2d301181e2367925029c7fbe2
Reviewed-on: https://chromium-review.googlesource.com/1056410
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559716}
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/chrome/browser/extensions/permission_message_combinations_unittest.cc
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/chrome/common/extensions/api/common_extension_api_unittest.cc
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/chrome/common/extensions/sync_type_unittest.cc
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/chrome/renderer/extensions/custom_types_unittest.cc
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/extensions/common/features/complex_feature.cc
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/extensions/common/features/complex_feature.h
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/extensions/common/features/complex_feature_unittest.cc
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/extensions/common/features/feature.h
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/extensions/common/features/simple_feature.cc
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/extensions/common/features/simple_feature.h
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/extensions/common/features/simple_feature_unittest.cc
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/tools/json_schema_compiler/feature_compiler.py
[modify] https://crrev.com/66536a464fc7894f18a3d93ab52a7124190144cc/tools/json_schema_compiler/test/features_generation_unittest.cc

Sign in to add a comment