Suggestion Shown/filled UKM are hard to analyse because they are missing FieldSignature and FormSignature. Add these fields to corresponding UKM.
Nik, can you add this?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dafac94b0fb50c8d6abe94dd97c3f8ff31c83813 commit dafac94b0fb50c8d6abe94dd97c3f8ff31c83813 Author: Nikunj Bhagat <nikunjb@chromium.org> Date: Fri May 18 19:07:58 2018 Add Form and Field signatures to Suggestion Shown. There will be a follow-up CL for adding them to SuggestionFilled also. Bug: 842370 Change-Id: I75c93dfdd960a653d2e7304188eea8099f0a7eaa Reviewed-on: https://chromium-review.googlesource.com/1057843 Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#559979} [modify] https://crrev.com/dafac94b0fb50c8d6abe94dd97c3f8ff31c83813/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/dafac94b0fb50c8d6abe94dd97c3f8ff31c83813/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/dafac94b0fb50c8d6abe94dd97c3f8ff31c83813/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/dafac94b0fb50c8d6abe94dd97c3f8ff31c83813/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/dafac94b0fb50c8d6abe94dd97c3f8ff31c83813/tools/metrics/ukm/ukm.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af01fe81d9fc2cc8e9a1e18a2c5d2502899c19d3 commit af01fe81d9fc2cc8e9a1e18a2c5d2502899c19d3 Author: Nikunj Bhagat <nikunjb@chromium.org> Date: Wed May 23 03:14:00 2018 Add form signature and field signature to SuggestionFilled UKM Add FormSignature to DeveloperEngagement The FormSignature and FieldSignature added here is similar to the signature added to Autofill_SuggestionShown UKM. Bug: 842370 Change-Id: I2b0cc9a387f0fd28d7b7eab3c345a581af055400 Reviewed-on: https://chromium-review.googlesource.com/1067678 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#560916} [modify] https://crrev.com/af01fe81d9fc2cc8e9a1e18a2c5d2502899c19d3/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/af01fe81d9fc2cc8e9a1e18a2c5d2502899c19d3/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/af01fe81d9fc2cc8e9a1e18a2c5d2502899c19d3/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/af01fe81d9fc2cc8e9a1e18a2c5d2502899c19d3/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/af01fe81d9fc2cc8e9a1e18a2c5d2502899c19d3/components/autofill/core/browser/form_structure.cc [modify] https://crrev.com/af01fe81d9fc2cc8e9a1e18a2c5d2502899c19d3/tools/metrics/ukm/ukm.xml
Also missing for TextFieldDidChange metric. Will add it there as well.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a773dfdcdf17136923be6e377eb5c6eb3e59c33b commit a773dfdcdf17136923be6e377eb5c6eb3e59c33b Author: Nikunj Bhagat <nikunjb@chromium.org> Date: Fri Jun 22 02:28:05 2018 Add FormSignature to TextFieldDidChange Bug: 842370 Change-Id: I5ecc2536c6f205c2d6974c555a46e227488d26e3 Reviewed-on: https://chromium-review.googlesource.com/1108551 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569511} [modify] https://crrev.com/a773dfdcdf17136923be6e377eb5c6eb3e59c33b/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/a773dfdcdf17136923be6e377eb5c6eb3e59c33b/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/a773dfdcdf17136923be6e377eb5c6eb3e59c33b/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/a773dfdcdf17136923be6e377eb5c6eb3e59c33b/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/a773dfdcdf17136923be6e377eb5c6eb3e59c33b/tools/metrics/ukm/ukm.xml
Comment 1 by rogerm@chromium.org
, May 15 2018