It will be replaced by OopAsh. We can't do this until ws2 is far enough along.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b8389a3ee51ffd8b16aed38d178d97535f039cd commit 2b8389a3ee51ffd8b16aed38d178d97535f039cd Author: Scott Violet <sky@chromium.org> Date: Sat May 12 01:59:15 2018 chromeos: Nuke kMash conditionals in ui/aura Aura-mus now only targets kMash. This means any conditional logic based on kMash can be removed (the true branch is all that is needed now). BUG=842365 TEST=none Change-Id: I01e444a3e04a3bf02123005ec793d112520aad00 Reviewed-on: https://chromium-review.googlesource.com/1055933 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#558095} [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ash/shell/content/client/shell_content_browser_client.cc [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ash/shell/content/client/shell_content_browser_client.h [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ash/shell_port_mus.cc [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ui/aura/mus/window_port_mus_unittest.cc [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ui/aura/mus/window_tree_client_unittest.cc [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ui/aura/mus/window_tree_host_mus.cc [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ui/aura/mus/window_tree_host_mus_init_params.h [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ui/aura/test/aura_test_base.cc [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ui/aura/test/aura_test_base.h [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ui/aura/window_event_dispatcher_unittest.cc [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ui/aura/window_targeter_unittest.cc [modify] https://crrev.com/2b8389a3ee51ffd8b16aed38d178d97535f039cd/ui/aura/window_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/360626addbfc77a51083bf8f05d023e132aa6e76 commit 360626addbfc77a51083bf8f05d023e132aa6e76 Author: Scott Violet <sky@chromium.org> Date: Wed Jul 11 15:55:50 2018 chromeos: renames kMash to kMashDeprecated and kOopAsh to kMash This also removes mash_ash_unittests as it's no longer applicable. There is a lot of cleanup that can happen, but I'm leaving that for future patches in hopes of not making this one too big. BUG= 855767 842365 840391 TEST=covered by tests Change-Id: If97385dc0e0b65974b8773043da55d576ff3d1fb Reviewed-on: https://chromium-review.googlesource.com/1131924 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#574181} [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/BUILD.gn [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/README.md [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/accessibility/accessibility_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/accessibility/accessibility_highlight_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/app_list/views/search_result_answer_card_view.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/ash_service.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/ash_service.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/display/display_color_manager.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/display/display_synchronizer.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/display/mirror_window_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/drag_drop/drag_drop_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/host/ash_window_tree_host_platform.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/ime/ime_focus_handler_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/keyboard/virtual_keyboard_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/keyboard/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/magnifier/magnification_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/pointer_watcher_adapter_classic_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/public/cpp/config.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/root_window_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shelf/shelf.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shelf/shelf_window_watcher.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shell.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shell_port_mash.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/flag_warning/flag_warning_tray_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/network/network_list.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/network/tray_network_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/network/wifi_toggle_notification_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/power/power_event_observer.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/unified/unified_system_tray_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/test/ash_test_base.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/test/ash_test_base.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/test/ash_test_helper.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/test/ash_test_suite.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/touch/touch_observer_hud_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/non_client_frame_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/window_util.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/wm_toplevel_window_event_handler.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/chrome/browser/ash_service_registry.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/chrome/utility/mash_service_factory.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/mash/test/mash_test_suite.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/services/ui/demo/mus_demo_unittests.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/services/ui/ws/window_server_test_base.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/chromium.memory.json [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/filters/BUILD.gn [delete] https://crrev.com/b954c230264648522a5e7f96812b174cd74276f9/testing/buildbot/filters/mash.ash_unittests.filter [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/filters/mash.browser_tests.filter [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/test_suites.pyl [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/aura_test_base.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/aura_test_helper.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/aura_test_helper.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/mus/test_window_tree_client_setup.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/mus/test_window_tree_client_setup.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/mus/window_tree_client_private.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/test_screen.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/base/ui_base_features.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/base/ui_base_features.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/views/mus/aura_init.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/views/mus/mus_client.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/views/mus/views_mus_test_suite.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597 commit dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597 Author: Scott Violet <sky@chromium.org> Date: Wed Jul 18 21:27:34 2018 chromeos: moves AppLaunch test to ash_unittests And makes it work with ash running the ws2. This necessiated providing support for ui::mojom::WindowServerTest in ws2. To get ash_unittests to connect to ash as a standalone service required a bit of tweaks to ash/main.cc. My plan is to fold (or delete) all of mash_unittests into ash_unittests. BUG=842365 TEST=covered by tests Change-Id: I37cd4b5a19f4570440bf4739b80eb5bd907da9c9 Reviewed-on: https://chromium-review.googlesource.com/1141063 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#576218} [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/ash/BUILD.gn [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/ash/OWNERS [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/ash/app_launch_unittest.cc [add] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/ash/ash_unittests_manifest.json [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/ash/main.cc [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/ash/test/DEPS [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/ash/test/ash_unittests.cc [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/BUILD.gn [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/client_root.cc [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/server_window.cc [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/server_window.h [add] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/window_server_test_impl.cc [add] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/window_server_test_impl.h [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/window_service.cc [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/window_service.h [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/window_tree.cc [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/window_tree.h [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/window_tree_binding.cc [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/window_tree_binding.h [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/window_tree_factory.cc [modify] https://crrev.com/dd9b796a8dbb5bd6f30cf3a762e3f7b5c69ad597/services/ui/ws2/window_tree_factory.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f76e64ab0b989f724ae60e0c2f61175cd84c50cd commit f76e64ab0b989f724ae60e0c2f61175cd84c50cd Author: Scott Violet <sky@chromium.org> Date: Fri Jul 20 05:17:03 2018 chromeos: nukes mash_unittests All interesting tests have been moved into ash_unittest and/or nuked. BUG=842365, 725095 , 838520 TEST=covered by tests Change-Id: I27069966c2ea214a071371b7959f4e44b533dd83 Reviewed-on: https://chromium-review.googlesource.com/1142622 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576786} [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ash/BUILD.gn [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ash/app_launch_unittest.cc [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ash/ash_service.cc [rename] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ash/ash_service_unittest.cc [delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/ash/display/display_synchronizer_unittest.cc [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ash/main.cc [delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/ash/wm/top_level_window_factory_mash_unittest.cc [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/mash/BUILD.gn [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/mash/OWNERS [delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/mash/test/DEPS [delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/mash/test/mash_test_suite.cc [delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/mash/test/mash_test_suite.h [delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/mash/test/mash_unittests.cc [delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/mash/unittests_manifest.json [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/testing/buildbot/chromium.memory.json [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/testing/buildbot/test_suites.pyl [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ui/aura/mus/in_flight_change.cc [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ui/aura/mus/window_tree_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c43ea0c68441a0269d8411dcae109d0afbd65478 commit c43ea0c68441a0269d8411dcae109d0afbd65478 Author: Scott Violet <sky@chromium.org> Date: Fri Jul 20 15:13:00 2018 chromeos: removes bunch of dead code from ash This is the easy parts of removing code that is no longer necessary with ws2. There is further cleanup/consolidation/merging to happen, but this is already a big enough change. BUG=842365 TEST=covered by tests Change-Id: I2cb9164a7cba9162004a560941b23c28d30e292b Reviewed-on: https://chromium-review.googlesource.com/1143011 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576865} [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/BUILD.gn [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/accelerators/accelerator_controller_registrar.cc [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/accelerators/accelerator_controller_registrar.h [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/accelerators/accelerator_handler.h [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/display/display_synchronizer.cc [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/display/display_synchronizer.h [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/root_window_controller.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/shell.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/shell.h [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/shell_init_params.h [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/shell_port_mash.cc [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/shell_port_mash.h [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/test/ash_test_base.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/test/ash_test_base.h [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/test/ash_test_helper.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/test/ash_test_helper.h [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/test/ash_test_suite.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/test/ash_test_suite.h [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/window_manager.cc [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/window_manager.h [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/window_manager_common_unittests.cc [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/window_manager_service.cc [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/window_manager_service.h [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/wm/move_event_handler.cc [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/wm/move_event_handler.h [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/wm/non_client_frame_controller.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/wm/non_client_frame_controller.h [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/wm/non_client_frame_controller_unittest.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/wm/top_level_window_factory.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/wm/top_level_window_factory.h [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/wm/top_level_window_factory_unittest.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/wm/window_properties.h [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/wm/window_util.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/wm/workspace/workspace_event_handler_classic.h [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/wm/workspace/workspace_event_handler_mash.cc [delete] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/ash/wm/workspace/workspace_event_handler_mash.h [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ash/ws/window_service_delegate_impl.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/chrome/browser/ui/ash/ash_shell_init.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/chrome/utility/mash_service_factory.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/services/ui/ws2/window_service.cc [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/services/ui/ws2/window_service.h [modify] https://crrev.com/c43ea0c68441a0269d8411dcae109d0afbd65478/ui/base/accelerators/accelerator_manager_delegate.h
Most of the work has been done here. There is still some random cleanup to be done, to which I'll file some bugs blocking this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcba678430c44543b62f9810286b3de4c4db22c9 commit dcba678430c44543b62f9810286b3de4c4db22c9 Author: Scott Violet <sky@chromium.org> Date: Mon Jul 23 17:17:52 2018 ash: removes AcceleratorHandler It's no longer used. BUG=842365 TEST=none (removal of dead code only) Change-Id: I7ec73de3686591c4697ea6b58dfbeeb5961d0648 Reviewed-on: https://chromium-review.googlesource.com/1146983 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#577195} [modify] https://crrev.com/dcba678430c44543b62f9810286b3de4c4db22c9/ash/BUILD.gn [delete] https://crrev.com/d726f5f692deb80f1014bee46c49b26d693366c3/ash/accelerators/accelerator_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def commit fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def Author: Scott Violet <sky@chromium.org> Date: Tue Jul 24 00:32:45 2018 removes support for ws1 from aura This removes ScreenProvider, WindowManagerClient and most of the WindowManager interface as they are not needed. Additionally this cleans up a couple of functions in WindowTree. Doing this showed a couple of test failures in aura. I'm making them early out for now and will investigate after this. The failures are because previously even though mus was configured some tests created WindowTreeHostPlatform, when I changed that to WindowTreeHostMus the tests started failing. BUG= 865689 ,842365 TEST=none Change-Id: Id5a67d7f513b2015a46a75745593ba122d17f6df Reviewed-on: https://chromium-review.googlesource.com/1146336 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#577370} [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ash/BUILD.gn [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ash/ash_service_unittest.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ash/components/autoclick/autoclick_application.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ash/components/tap_visualizer/tap_visualizer_app.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ash/display/mirror_window_controller.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ash/display/mirror_window_controller.h [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ash/event_matcher_util.cc [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ash/event_matcher_util.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ash/frame/detached_title_area_renderer.cc [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ash/host/ash_window_tree_host_mus.cc [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ash/host/ash_window_tree_host_mus.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ash/host/ash_window_tree_host_platform.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ash/wm/non_client_frame_controller.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ash/wm/top_level_window_factory.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ash/wm/top_level_window_factory_unittest.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/chrome/utility/DEPS [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/content/renderer/mus/renderer_window_tree_client.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/content/renderer/mus/renderer_window_tree_client.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/common/BUILD.gn [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/services/ui/common/accelerator_util.cc [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/services/ui/common/accelerator_util.h [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/services/ui/common/image_cursors_set.cc [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/services/ui/common/image_cursors_set.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/common/switches.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/manifest.json [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/public/interfaces/BUILD.gn [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/services/ui/public/interfaces/event_matcher.mojom [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/public/interfaces/screen_provider.mojom [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/public/interfaces/window_manager.mojom [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/public/interfaces/window_manager_constants.mojom [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/services/ui/public/interfaces/window_manager_window_tree_factory.mojom [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/public/interfaces/window_tree.mojom [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/ws2/test_change_tracker.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/ws2/test_change_tracker.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/ws2/test_window_tree_client.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/ws2/test_window_tree_client.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/ws2/window_service.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/ws2/window_tree.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/ws2/window_tree.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/services/ui/ws2/window_tree_client_unittest.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/BUILD.gn [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/client/aura_constants.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/env.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/hit_test_data_provider_aura_unittest.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/drag_drop_controller_mus_unittest.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/mus_types.h [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ui/aura/mus/platform_event_source_mus_ozone.cc [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ui/aura/mus/platform_event_source_mus_ozone.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/property_converter.cc [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ui/aura/mus/system_input_injector_mus_unittest.cc [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ui/aura/mus/window_manager_delegate.cc [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ui/aura/mus/window_manager_delegate.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/window_port_mus.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/window_tree_client_unittest.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/window_tree_host_mus.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/window_tree_host_mus.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/window_tree_host_mus_delegate.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/window_tree_host_mus_init_params.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/mus/window_tree_host_mus_init_params.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/aura_mus_test_base.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/aura_mus_test_base.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/aura_test_base.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/aura_test_base.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/aura_test_helper.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/aura_test_helper.h [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ui/aura/test/mus/test_window_manager_client.cc [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ui/aura/test/mus/test_window_manager_client.h [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ui/aura/test/mus/test_window_manager_delegate.cc [delete] https://crrev.com/a603fbbfea00da9598f14b624ba75955b3ec29d8/ui/aura/test/mus/test_window_manager_delegate.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/mus/test_window_tree.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/mus/test_window_tree.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/mus/test_window_tree_client_setup.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/mus/test_window_tree_client_setup.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/mus/window_tree_client_private.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/mus/window_tree_client_private.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/test/test_screen.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/window_event_dispatcher_unittest.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/window_targeter_unittest.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/window_tree_host_observer.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/aura/window_unittest.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/views/mus/mus_client.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/views/mus/screen_mus.h [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/wm/core/easy_resize_window_targeter.cc [modify] https://crrev.com/fd9a3b687e1f7ab09cb68242fc9d70e2e2cc5def/ui/wm/test/wm_test_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b093590ba3644fb4a13dc38832116bffd9ea9e2d commit b093590ba3644fb4a13dc38832116bffd9ea9e2d Author: Scott Violet <sky@chromium.org> Date: Tue Jul 24 18:27:37 2018 chromeos: removes kMashDeprecated BUG=842365 TEST=none Change-Id: I4006ea0b9fd59d183620b90aafa182a239e9bfb7 Reviewed-on: https://chromium-review.googlesource.com/1146994 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#577617} [modify] https://crrev.com/b093590ba3644fb4a13dc38832116bffd9ea9e2d/ash/app_list/views/search_result_answer_card_view.cc [modify] https://crrev.com/b093590ba3644fb4a13dc38832116bffd9ea9e2d/ash/display/display_color_manager.cc [modify] https://crrev.com/b093590ba3644fb4a13dc38832116bffd9ea9e2d/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/b093590ba3644fb4a13dc38832116bffd9ea9e2d/chrome/browser/ash_service_registry.cc [modify] https://crrev.com/b093590ba3644fb4a13dc38832116bffd9ea9e2d/chrome/browser/media/cast_mirroring_service_host_browsertest.cc [modify] https://crrev.com/b093590ba3644fb4a13dc38832116bffd9ea9e2d/ui/base/ui_base_features.cc [modify] https://crrev.com/b093590ba3644fb4a13dc38832116bffd9ea9e2d/ui/base/ui_base_features.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97a7b9d5b71bce2a2370f9d57d7de4be462dce91 commit 97a7b9d5b71bce2a2370f9d57d7de4be462dce91 Author: Scott Violet <sky@chromium.org> Date: Mon Aug 06 22:31:13 2018 chromeos: removes dead code in Shell BUG=842365 TEST=none Change-Id: I3f29c66f1d82c88eaff7da4c8b99ee6aed4902cc Reviewed-on: https://chromium-review.googlesource.com/1164075 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581013} [modify] https://crrev.com/97a7b9d5b71bce2a2370f9d57d7de4be462dce91/ash/shell.cc [modify] https://crrev.com/97a7b9d5b71bce2a2370f9d57d7de4be462dce91/ash/shell.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31bb3259583fdcef09b9f3a8758f0a0a902333f7 commit 31bb3259583fdcef09b9f3a8758f0a0a902333f7 Author: James Cook <jamescook@chromium.org> Date: Wed Aug 08 20:06:44 2018 Rename ash::PointerWatcherAdapterClassic to PointerWatcherAdapter There isn't a separate "classic" mode for ash anymore. Bug: 842365 Test: ash_unittests Change-Id: I52d758904cb0dc579e69e84c8ebd259e81aef7e2 Reviewed-on: https://chromium-review.googlesource.com/1167748 Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#581675} [modify] https://crrev.com/31bb3259583fdcef09b9f3a8758f0a0a902333f7/ash/BUILD.gn [rename] https://crrev.com/31bb3259583fdcef09b9f3a8758f0a0a902333f7/ash/pointer_watcher_adapter.cc [rename] https://crrev.com/31bb3259583fdcef09b9f3a8758f0a0a902333f7/ash/pointer_watcher_adapter.h [rename] https://crrev.com/31bb3259583fdcef09b9f3a8758f0a0a902333f7/ash/pointer_watcher_adapter_unittest.cc [modify] https://crrev.com/31bb3259583fdcef09b9f3a8758f0a0a902333f7/ash/shell.cc [modify] https://crrev.com/31bb3259583fdcef09b9f3a8758f0a0a902333f7/ash/shell.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd commit bed23cbbf339728dd0432bbad3cb1f5cfdb155fd Author: Scott Violet <sky@chromium.org> Date: Wed Aug 22 19:56:12 2018 chromeos: cleans up display related mojoms This removes the mojom interfaces DevDisplayController and DisplayController which are unused. OutputProtection is still necessary. As OutputProtection is now provided by ash, OutputProtection has been moved to ash. Additionally, OutputProtection has been renamed to DisplayOutputProtection. OutputProtection was previously in the display namespace, so that renaming to DisplayOutputProtection makes it more obvious what the class is for. BUG=842365 TEST=none Change-Id: I1f469032fc991139964b04b9740da64abafa89e0 Reviewed-on: https://chromium-review.googlesource.com/1183892 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#585215} [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/ash/BUILD.gn [add] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/ash/display/display_output_protection.cc [add] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/ash/display/display_output_protection.h [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/ash/manifest.json [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/ash/mojo_interface_factory.cc [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/ash/public/interfaces/BUILD.gn [rename] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/ash/public/interfaces/display_output_protection.mojom [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/ash/shell.cc [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/ash/shell.h [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/chrome/browser/chromeos/display/output_protection_controller_mus.cc [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/chrome/browser/chromeos/display/output_protection_controller_mus.h [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/services/BUILD.gn [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/BUILD.gn [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/OWNERS [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/output_protection.cc [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/output_protection.h [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/screen_manager.cc [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/screen_manager.h [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/screen_manager_delegate.h [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/screen_manager_forwarding.cc [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/screen_manager_forwarding.h [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/screen_manager_ozone_external.cc [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/screen_manager_ozone_external.h [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/screen_manager_ozone_internal.cc [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/screen_manager_ozone_internal.h [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/screen_manager_ozone_internal_unittests.cc [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/screen_manager_stub_internal.cc [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/screen_manager_stub_internal.h [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/viewport_metrics.cc [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/display/viewport_metrics.h [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/services/ui/manifest.json [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/services/ui/public/interfaces/BUILD.gn [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/public/interfaces/display/BUILD.gn [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/public/interfaces/display/OWNERS [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/services/ui/public/interfaces/display/display_controller.mojom [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/ui/display/manager/display_manager.cc [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/ui/display/manager/display_manager.h [modify] https://crrev.com/bed23cbbf339728dd0432bbad3cb1f5cfdb155fd/ui/display/mojo/BUILD.gn [delete] https://crrev.com/13de6cf8cd4f85994a51d551b8df3b3813b77631/ui/display/mojo/dev_display_controller.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3095a12ea5b0bf6d8329dc86729263824c820887 commit 3095a12ea5b0bf6d8329dc86729263824c820887 Author: James Cook <jamescook@chromium.org> Date: Thu Sep 13 22:25:22 2018 chromeos: Eliminate WorkspaceEventHandlerClassic It was the only subclass of WorkspaceEventHandler, so fold it into the superclass. This is left over from pre-WS2 mustash, when we had a separate ash config for mash. Bug: 842365, 866528 Test: ash_unittests, double-click window borders to resize windows Change-Id: I5de319afb6e8e00b51130a9099fc7c3e9ef70cfc Reviewed-on: https://chromium-review.googlesource.com/1225596 Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#591185} [modify] https://crrev.com/3095a12ea5b0bf6d8329dc86729263824c820887/ash/BUILD.gn [modify] https://crrev.com/3095a12ea5b0bf6d8329dc86729263824c820887/ash/wm/workspace/workspace_event_handler.cc [modify] https://crrev.com/3095a12ea5b0bf6d8329dc86729263824c820887/ash/wm/workspace/workspace_event_handler.h [delete] https://crrev.com/eefccbdc53b8841ba0a5791b5305a0f38759f2e9/ash/wm/workspace/workspace_event_handler_classic.cc [delete] https://crrev.com/eefccbdc53b8841ba0a5791b5305a0f38759f2e9/ash/wm/workspace/workspace_event_handler_classic.h [modify] https://crrev.com/3095a12ea5b0bf6d8329dc86729263824c820887/ash/wm/workspace_controller.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dafb54f4289842a087e7cf14f1a673e74f930ea1 commit dafb54f4289842a087e7cf14f1a673e74f930ea1 Author: James Cook <jamescook@chromium.org> Date: Fri Sep 14 16:36:15 2018 Remove ui::AcceleratorManagerDelegate It was added in the early days of mustash to support the mus window server. Now that we have WS2 / window service as a part of ash it isn't needed anymore. It was only being used in tests. Bug: 842365, 866526 Test: ui_base_unittests, ash_unittests, manually try accelerators Change-Id: Ib156f42103ef21c6cdaf95183bf828d0959ad84e Reviewed-on: https://chromium-review.googlesource.com/1225594 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#591370} [modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ash/accelerators/accelerator_controller.h [modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ash/shell.cc [modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ui/base/BUILD.gn [modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ui/base/accelerators/accelerator_manager.cc [modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ui/base/accelerators/accelerator_manager.h [delete] https://crrev.com/f47bbab27c0de5810f7db4d75c886ff0620d3fe5/ui/base/accelerators/accelerator_manager_delegate.h [modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ui/base/accelerators/accelerator_manager_unittest.cc
Comment 1 by bugdroid1@chromium.org
, May 12 2018