New issue
Advanced search Search tips

Issue 842364 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Allow auto-retries on network changed errors in the component updater

Project Member Reported by sorin@chromium.org, May 11 2018

Issue description

We want to enable retrying on network changed errors in the component updater request sender and downloader.

On mobile devices, this network error may be transient, and automatic retrying may allow the component updater to gracefully handle this condition and continue
execution.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56b48e70b8bdc17406d25eae4336c31c9246c6b2

commit 56b48e70b8bdc17406d25eae4336c31c9246c6b2
Author: Sorin Jianu <sorin@chromium.org>
Date: Mon May 14 18:04:27 2018

Allow auto-retries on network changed errors in the component updater.

The retries are set to 3, as most of the Chromium code using the
url fetcher does.

Bug:  842364 
Change-Id: I0f6e295231c36301c6ca44806233f841d316b58e
Reviewed-on: https://chromium-review.googlesource.com/1056222
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558374}
[modify] https://crrev.com/56b48e70b8bdc17406d25eae4336c31c9246c6b2/components/update_client/url_fetcher_downloader.cc
[modify] https://crrev.com/56b48e70b8bdc17406d25eae4336c31c9246c6b2/components/update_client/utils.cc

Comment 2 by sorin@chromium.org, May 14 2018

Status: Fixed (was: Started)

Sign in to add a comment