New issue
Advanced search Search tips

Issue 842361 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Get WindowPortMusTest.LayerTreeFrameSinkGetsCorrectLocalSurfaceId working without mushrome

Project Member Reported by sky@chromium.org, May 11 2018

Issue description

I'm removing the mushrome code path from ui/aura/mus. WindowPortMusTest.LayerTreeFrameSinkGetsCorrectLocalSurfaceId fails:

[ RUN      ] WindowPortMusTest.LayerTreeFrameSinkGetsCorrectLocalSurfaceId
../../ui/aura/mus/window_port_mus_unittest.cc:46: Failure
Value of: local_surface_id.is_valid()
  Actual: false
Expected: true
Stack trace:
#0 0x000000a980d0 StackTraceGetter::CurrentStackTrace()
#1 0x000000abe1b7 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#2 0x000000abd61d testing::internal::AssertHelper::operator=()
#3 0x00000054b6ba aura::WindowPortMusTest_LayerTreeFrameSinkGetsCorrectLocalSurfaceId_Test::TestBody()
#4 0x000000af739e testing::internal::HandleSehExceptionsInMethodIfSupported<>()

[  FAILED  ] WindowPortMusTest.LayerTreeFrameSinkGetsCorrectLocalSurfaceId (38 ms)
[----------] 1 test from WindowPortMusTest (38 ms total)

I've disabled the test for now. If the assertions are still valid, we should fix. Otherwise nuke.
 

Sign in to add a comment