New issue
Advanced search Search tips

Issue 842354 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 842296



Sign in to add a comment

Rename shared-module extension field "whitelist" to "allowlist"

Project Member Reported by jyasskin@chromium.org, May 11 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4

commit 9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri May 18 05:42:04 2018

[Extensions] Use `allowlist` in SharedModule code

Rename the shared module property to 'allowlist'. The legacy 'whitelist'
key will continue to work until we update any uses of it.

Bug: 842354

Change-Id: Ie39179c91115a043f32c5329615188b01a119578
Reviewed-on: https://chromium-review.googlesource.com/1064608
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559808}
[modify] https://crrev.com/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4/chrome/browser/extensions/crx_installer.cc
[modify] https://crrev.com/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4/extensions/common/manifest_constants.cc
[modify] https://crrev.com/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4/extensions/common/manifest_constants.h
[modify] https://crrev.com/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4/extensions/common/manifest_handlers/shared_module_info.cc
[modify] https://crrev.com/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4/extensions/common/manifest_handlers/shared_module_info.h
[modify] https://crrev.com/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4/extensions/common/manifest_handlers/shared_module_manifest_unittest.cc
[modify] https://crrev.com/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4/extensions/test/data/manifest_tests/shared_module_export.json
[rename] https://crrev.com/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4/extensions/test/data/manifest_tests/shared_module_export_allowlist_item_not_id.json
[rename] https://crrev.com/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4/extensions/test/data/manifest_tests/shared_module_export_allowlist_item_not_string.json
[rename] https://crrev.com/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4/extensions/test/data/manifest_tests/shared_module_export_allowlist_not_list.json
[rename] https://crrev.com/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4/extensions/test/data/manifest_tests/shared_module_export_no_allowlist.json
[copy] https://crrev.com/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4/extensions/test/data/manifest_tests/shared_module_legacy_allowlist.json

Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d7e8661bfd99a40c97f5cec76e67c54b02e22c5

commit 4d7e8661bfd99a40c97f5cec76e67c54b02e22c5
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue May 22 20:30:37 2018

[Extensions Docs] Use allowlist in shared modules documentation

https://crrev.com/9486b056 updated shared module code to use allowlist;
update the documentation to match.

TBR=mkearney@chromium.org

Bug: 842354
Change-Id: I2663de6faa05a7322ee9c63bfab73c6777da1532
Reviewed-on: https://chromium-review.googlesource.com/1068206
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560758}
[modify] https://crrev.com/4d7e8661bfd99a40c97f5cec76e67c54b02e22c5/chrome/common/extensions/docs/templates/articles/shared_modules.html

Sign in to add a comment