New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842351 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 879308
Owner:
Last visit > 30 days ago
Closed: Nov 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

viz hit-test support for ws2

Project Member Reported by riajiang@chromium.org, May 11 2018

Issue description

viz hit-test doesn't work with mash yet but we have that codepath (https://cs.chromium.org/chromium/src/services/ui/ws/event_targeter.cc?type=cs&q=findtargetforlocation&l=56) in EventTargeter, so mash_browser_tests would fail when we enable viz hit-test (VizHitTestDrawQuad) by default. I'm going to delete that codepath in EventTargeter for now; will make sure it works when we need to support viz hit-test for ws2.

assigning gklassen@ for triage when this needs to happen for ws2.
 
Cc: rjkroege@chromium.org sadrul@chromium.org riajiang@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c149a22ae0015b9c6d625895bb3690fc5f5d4af

commit 0c149a22ae0015b9c6d625895bb3690fc5f5d4af
Author: Ria Jiang <riajiang@chromium.org>
Date: Wed May 16 17:06:39 2018

Delete Viz hit-test codepath in ws::EventTargeter.

Viz hit-test doesn't work with mash completely yet so some
mash_browser_tests would fail (e.g. [1]) when we enable Viz
hit-test (feature VizHitTestDrawQuad) by default. Deleting
that codepath in this CL since it's not used anyway and will
revisit/debug when we need to add support for WS in Viz
hit-test.

[1] https://chromium-swarm.appspot.com/task?id=3d693515ea5b4310&refresh=10&show_raw=1

Bug:  842351 
Change-Id: Id75b342427e231b209c90dbc1b603d65c5639fd0
Reviewed-on: https://chromium-review.googlesource.com/1058438
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559150}
[modify] https://crrev.com/0c149a22ae0015b9c6d625895bb3690fc5f5d4af/services/ui/ws/event_processor_unittest.cc
[modify] https://crrev.com/0c149a22ae0015b9c6d625895bb3690fc5f5d4af/services/ui/ws/event_targeter.cc

same as issue 879308 ?
Mergedinto: 879308
Status: Duplicate (was: Assigned)

Sign in to add a comment