Rename Chrome flag for disabling previews blacklist |
|||||||||
Issue descriptionRename chrome://flags/#ignore-previews-blacklist to chrome://flags/#ignore-previews-blocklist. See Issue 842296 and https://chromium-review.googlesource.com/c/chromium/src/+/1055905 for more details. The general goal is to avoid using the term "blacklist" especially if it appears in the UI.
,
May 11 2018
,
May 11 2018
,
Jun 22 2018
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c3dbc98a3f6611193184b5b4778639730b0ee33 commit 8c3dbc98a3f6611193184b5b4778639730b0ee33 Author: Ryan Sturm <ryansturm@chromium.org> Date: Tue Jun 26 19:22:37 2018 UI strings Blacklist->Blocklist in about:flags Moving the "blacklist" strings in previews about:flags to a "blocklist" string. Bug: 842346 Change-Id: Ib4dd84e1ee63b6cd7d5c3d9cdd6d5b704d06cf90 Reviewed-on: https://chromium-review.googlesource.com/1115420 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#570489} [modify] https://crrev.com/8c3dbc98a3f6611193184b5b4778639730b0ee33/chrome/browser/flag_descriptions.cc
,
Jun 26 2018
,
Jun 27 2018
Tested this issue on Windows 10, Debian Rodete and Mac 10.13.5 with chrome #69.0.3474.0 and observed the fix is not working as intended. Still seeing the flag as #ignore-previews-blacklist Attaching the screen-cast for reference. ryansturm@ Could you please look into this and let us know your observations
,
Jun 27 2018
I only fixed the actual strings. I'll fix the rest now.
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97a5cd4c6c9e65fcb895498a03b24a95cd256d2f commit 97a5cd4c6c9e65fcb895498a03b24a95cd256d2f Author: Ryan Sturm <ryansturm@chromium.org> Date: Wed Jun 27 20:51:43 2018 blacklist->blocklist in flag Bug: 842346 Change-Id: I7ed7cd5ab42a97ce0bb10d644a7904a191f2547a Reviewed-on: https://chromium-review.googlesource.com/1117302 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#570895} [modify] https://crrev.com/97a5cd4c6c9e65fcb895498a03b24a95cd256d2f/chrome/browser/about_flags.cc [modify] https://crrev.com/97a5cd4c6c9e65fcb895498a03b24a95cd256d2f/tools/metrics/histograms/enums.xml
,
Jun 27 2018
,
Jun 28 2018
Verified this issue on Windows 10, Debian Rodete and Mac 10.13.5 with chrome #69.0.3475.0 and observed the fix is working as intended, hence adding TE verified labels. Attaching the screenshot for reference. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tbansal@chromium.org
, May 11 2018