These are only used for logging the PreconnectUtilization2 metric, which is unused at this point.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e839a7c5ced9afc17892d598a6446ae4e3356bf4 commit e839a7c5ced9afc17892d598a6446ae4e3356bf4 Author: Charlie Harrison <csharrison@chromium.org> Date: Fri May 11 22:47:03 2018 Remove PreconnectUtilization2 histogram This histogram is not being used and is not fully functional. This CL was split from crrev.com/c/1055738, and removes UseHistory from StreamSocket and TCPClientSocket. Follow-ups will remove HttpRequestInfo::RequestMotivation and Two StreamSocket methods that are no effectively no-ops. Bug: 629382, 842337 Change-Id: Ieff43ffe0a1ede69a517217bcd9f3af15e57e8c1 Reviewed-on: https://chromium-review.googlesource.com/1055761 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558044} [modify] https://crrev.com/e839a7c5ced9afc17892d598a6446ae4e3356bf4/net/socket/stream_socket.cc [modify] https://crrev.com/e839a7c5ced9afc17892d598a6446ae4e3356bf4/net/socket/stream_socket.h [modify] https://crrev.com/e839a7c5ced9afc17892d598a6446ae4e3356bf4/net/socket/tcp_client_socket.cc [modify] https://crrev.com/e839a7c5ced9afc17892d598a6446ae4e3356bf4/net/socket/tcp_client_socket.h [modify] https://crrev.com/e839a7c5ced9afc17892d598a6446ae4e3356bf4/net/socket/tcp_client_socket_unittest.cc [modify] https://crrev.com/e839a7c5ced9afc17892d598a6446ae4e3356bf4/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e4c0624014576302a8317ea447c6104518beb24 commit 3e4c0624014576302a8317ea447c6104518beb24 Author: Charlie Harrison <csharrison@chromium.org> Date: Sun May 13 15:44:30 2018 Remove Set*Speculation methods from StreamSocket These methods aren't being used anymore. This CL also removes some tests which exercise these methods. This CL was split from https://chromium-review.googlesource.com/c/chromium/src/+/1055738 Bug: 842337 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo TBR=slan@chromium.org,jochen@chromium.org,sergeyu@chromium.org Change-Id: Ie695e2e1ab33cc13ebf8abc6e148251e0c4ec70c Reviewed-on: https://chromium-review.googlesource.com/1056108 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#558158} [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/chrome/browser/devtools/device/usb/android_usb_socket.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/chrome/browser/devtools/device/usb/android_usb_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/chrome/browser/extensions/api/socket/mock_tcp_client_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/chrome/browser/extensions/api/socket/tls_socket_unittest.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/chromecast/net/fake_stream_socket.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/chromecast/net/fake_stream_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/chromecast/net/mock_stream_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/content/browser/renderer_host/p2p/socket_host_test_utils.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/content/browser/renderer_host/p2p/socket_host_test_utils.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/jingle/glue/fake_ssl_client_socket.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/jingle/glue/fake_ssl_client_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/jingle/glue/fake_ssl_client_socket_unittest.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/http/http_proxy_client_socket.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/http/http_proxy_client_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/http/http_proxy_client_socket_wrapper.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/http/http_proxy_client_socket_wrapper.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/quic/chromium/quic_proxy_client_socket.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/quic/chromium/quic_proxy_client_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/server/http_server_unittest.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/client_socket_pool_base.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/client_socket_pool_base_unittest.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/fuzzed_socket.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/fuzzed_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/fuzzed_socket_factory.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/socket_test_util.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/socket_test_util.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/socks5_client_socket.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/socks5_client_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/socks_client_socket.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/socks_client_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/ssl_client_socket_impl.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/ssl_client_socket_impl.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/ssl_server_socket_impl.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/ssl_server_socket_unittest.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/stream_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/tcp_client_socket.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/tcp_client_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/transport_client_socket_pool_test_util.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/unix_domain_client_socket_posix.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/unix_domain_client_socket_posix.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/socket/websocket_endpoint_lock_manager_unittest.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/spdy/spdy_proxy_client_socket.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/net/spdy/spdy_proxy_client_socket.h [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/remoting/protocol/ssl_hmac_channel_authenticator.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/services/network/proxy_resolving_client_socket.cc [modify] https://crrev.com/3e4c0624014576302a8317ea447c6104518beb24/services/network/proxy_resolving_client_socket.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc commit 55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc Author: Charlie Harrison <csharrison@chromium.org> Date: Mon May 14 02:25:57 2018 Remove HttpRequestInfo::RequestMotivation This information is no longer being used anywhere. TBR=avi@chromium.org Bug: 842337 Change-Id: Iacdffd68df415a90ffe1b2c63971bd2c327d5cb0 Reviewed-on: https://chromium-review.googlesource.com/1056167 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#558177} [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/chrome/browser/chromeos/login/auth/auth_prewarmer.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/chrome/browser/net/predictor.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/chrome/browser/predictors/preconnect_manager.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/content/browser/loader/resource_hints_impl.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/content/public/browser/resource_hints.h [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/http/http_network_transaction_unittest.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/http/http_proxy_client_socket_pool.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/http/http_proxy_client_socket_pool.h [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/http/http_request_info.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/http/http_request_info.h [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/http/http_stream_factory_job.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/http/http_stream_factory_job.h [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/http/http_stream_factory_unittest.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/client_socket_pool.h [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/client_socket_pool_base.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/client_socket_pool_base.h [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/client_socket_pool_base_unittest.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/client_socket_pool_manager.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/client_socket_pool_manager.h [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/socks_client_socket_pool.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/socks_client_socket_pool.h [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/ssl_client_socket_pool.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/ssl_client_socket_pool.h [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/transport_client_socket_pool.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/transport_client_socket_pool.h [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/websocket_transport_client_socket_pool.cc [modify] https://crrev.com/55ce608d69d0bc5066a55fdaa0d6f71cb2b9d7cc/net/socket/websocket_transport_client_socket_pool.h
Comment 1 by bugdroid1@chromium.org
, May 11 2018