power button menu was introduced from M67, hoping to merge this issue back to M67 too. Since we haven't supported ChromeVox for the menu in M67 yet.

This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Two thoughts:
(1) I think we don't need restrict view here
(2) merge request should be asked until CL is landed

I know (2) was different for m61 launch...

for (1) do you mean "Power off" item? I mentioned it just because we focus on it when the menu is invoked. Then we will change the focus when using keyboard navigation.

for (2) yeah, i did this during launcher implementation. Got it. Thanks Joe.

That is what I mean : )

Has fix been fully tested?  What is the CL you're asking me to merge?

M67 is already in beta; prefer to wait for M68 unless there's reason not to.

Thanks

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b013458806a073a78d15d153763f2655daea91df

commit b013458806a073a78d15d153763f2655daea91df
Author: Min Chen <minch@google.com>
Date: Mon May 14 22:24:17 2018

Focus on power button menu when it is invoked.

Focus on power button menu instead of "Power off" item when menu is opened.
This is used to make sure PowerButtonMenuView can still handle the key events
when menu is opened. Since we still need ESCAPE to dismiss the menu and TAB or
direction keys to navigate between menu items.

Bug:  842336 
Change-Id: I4d951e6d520dd28e88362c85e25ef156a1252f30
Reviewed-on: https://chromium-review.googlesource.com/1056294
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558493}
[modify] https://crrev.com/b013458806a073a78d15d153763f2655daea91df/ash/system/power/power_button_controller.cc
[modify] https://crrev.com/b013458806a073a78d15d153763f2655daea91df/ash/system/power/power_button_controller_unittest.cc
[modify] https://crrev.com/b013458806a073a78d15d153763f2655daea91df/ash/system/power/power_button_menu_view.cc

Hi kbleicher@, the cl just be merged and yes, i tested it on my own device and it works well. The power button menu was introduced in M67 and i guess we want to merge this change to M67 is because we want to make the focus the same as other parts in the system. Like system tray, it has no focus indicator until user beings keyboard navigation.
Please help take a look of the cl, thanks.

Is this tied to a feature that was approved for M67?  Assume so per #1 and this is a fix for that feature release?

I think this is an improvement of the feature here https://bugs.chromium.org/p/chromium/issues/detail?id=732628&desc=3, which was approved for M67. We want to make it look better in M67.

Is adding the feature bug to "Blocking" the best way to communicate this?

#11; helps; thanks Dan.

Approving merge to M67 Chrome OS.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47332a3854ca9d29568a0acabbfb2f32953b7a6e

commit 47332a3854ca9d29568a0acabbfb2f32953b7a6e
Author: Min Chen <minch@google.com>
Date: Thu May 17 21:23:23 2018

[Merge to M67]Focus on power button menu when it is invoked.

TBR=minch@chromium.org

Focus on power button menu instead of "Power off" item when menu is opened.
This is used to make sure PowerButtonMenuView can still handle the key events
when menu is opened. Since we still need ESCAPE to dismiss the menu and TAB or
direction keys to navigate between menu items.

(cherry picked from commit b013458806a073a78d15d153763f2655daea91df)

Bug:  842336 
Change-Id: I4d951e6d520dd28e88362c85e25ef156a1252f30
Reviewed-on: https://chromium-review.googlesource.com/1056294
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#558493}
Reviewed-on: https://chromium-review.googlesource.com/1064547
Reviewed-by: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#627}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/47332a3854ca9d29568a0acabbfb2f32953b7a6e/ash/system/power/power_button_controller.cc
[modify] https://crrev.com/47332a3854ca9d29568a0acabbfb2f32953b7a6e/ash/system/power/power_button_controller_unittest.cc
[modify] https://crrev.com/47332a3854ca9d29568a0acabbfb2f32953b7a6e/ash/system/power/power_button_menu_view.cc