//gpu/vulkan android code needs repairs |
||||||
Issue description
Chrome contains code to support vulkan on Android:
gpu/vulkan/vulkan_device_queue.cc
gpu/vulkan/vulkan_implementation.cc
gpu/vulkan/vulkan_platform.h
gpu/vulkan/vulkan_surface.cc
content/browser/renderer_host/compositor_impl_android.cc
However, it does not seem possible to compile this code currently. gn gen fails:
n gen --args='target_os="android" enable_vulkan=true' out/android_vulkan
ERROR at //gpu/vulkan/BUILD.gn:90:7: Assertion failed.
assert(false, "Unsupported vulkan target: " + current_cpu)
^-----
Unsupported vulkan target: arm
See //cc/BUILD.gn:380:5: which caused the file to be included.
"//gpu/vulkan:buildflags",
^------------------------
,
May 18 2018
,
Jun 5 2018
cblume@ is working on getting Vulkan building, including some clean up I believe. Over to him.
,
Jun 6 2018
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4264428b06a891e13315d57ffb04532d7c6d7b8 commit e4264428b06a891e13315d57ffb04532d7c6d7b8 Author: Chris Blume <cblume@chromium.org> Date: Tue Jul 10 04:56:24 2018 Fix Vulkan build on Android Building for Android with Vulkan support previously did not work. There was some existing Android + Vulkan code which needed a little clean up. This patch enables Vulkan support on Android builds. BUG=842302, 850725 ,848375 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I077fe775c7d387e5c65c0024e88421ba47ce6280 Reviewed-on: https://chromium-review.googlesource.com/1110754 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#573613} [modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/android_webview/browser/parent_output_surface.cc [modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/android_webview/browser/parent_output_surface.h [modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/content/browser/BUILD.gn [modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/content/browser/renderer_host/compositor_impl_android.h [modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/content/renderer/android/synchronous_layer_tree_frame_sink.cc [modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/BUILD.gn [add] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/android/BUILD.gn [rename] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/android/vulkan_implementation_android.cc [rename] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/android/vulkan_implementation_android.h [modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/features.gni [modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/init/BUILD.gn [modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/init/vulkan_factory.cc [modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/skia/config/SkVulkanConfig.h
,
Oct 24
,
Oct 29
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by spang@chromium.org
, May 11 2018