New issue
Advanced search Search tips

Issue 842298 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 837684



Sign in to add a comment

Wire up NonClientFrameController's ClientViewMus::CanClose in window-service as a library

Project Member Reported by msw@chromium.org, May 11 2018

Issue description

Wire up NonClientFrameController's ClientViewMus::CanClose in window-service as a library

I'm stubbing out this behavior from the original window service for now in:
 https://chromium-review.googlesource.com/c/chromium/src/+/1055658/6/ash/wm/non_client_frame_controller.cc
We'll need something to replace the WindowManagerClient::RequestClose.
 

Comment 1 by sky@chromium.org, Jun 5 2018

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94392859d28397a3b0260fd7add1e776d965e9dc

commit 94392859d28397a3b0260fd7add1e776d965e9dc
Author: Scott Violet <sky@chromium.org>
Date: Wed Jun 06 15:23:23 2018

chromeos: adds support for RequestClose and wires up in ash

When a remote client creates a window, the remote client should control when it
is closed. This makes it to so that when the user attemps to close a window
created by a remote client, the remote client is asked to close the window.

BUG= 842298 
TEST=covered by test

Change-Id: I9ace655c0648fc0f8943425c67fb57e088ef00fa
Reviewed-on: https://chromium-review.googlesource.com/1087870
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564897}
[modify] https://crrev.com/94392859d28397a3b0260fd7add1e776d965e9dc/ash/BUILD.gn
[modify] https://crrev.com/94392859d28397a3b0260fd7add1e776d965e9dc/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/94392859d28397a3b0260fd7add1e776d965e9dc/ash/wm/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/94392859d28397a3b0260fd7add1e776d965e9dc/services/ui/ws2/test_change_tracker.cc
[modify] https://crrev.com/94392859d28397a3b0260fd7add1e776d965e9dc/services/ui/ws2/test_change_tracker.h
[modify] https://crrev.com/94392859d28397a3b0260fd7add1e776d965e9dc/services/ui/ws2/test_window_tree_client.cc
[modify] https://crrev.com/94392859d28397a3b0260fd7add1e776d965e9dc/services/ui/ws2/window_service.cc
[modify] https://crrev.com/94392859d28397a3b0260fd7add1e776d965e9dc/services/ui/ws2/window_service.h
[modify] https://crrev.com/94392859d28397a3b0260fd7add1e776d965e9dc/services/ui/ws2/window_service_client.cc
[modify] https://crrev.com/94392859d28397a3b0260fd7add1e776d965e9dc/services/ui/ws2/window_service_client.h
[modify] https://crrev.com/94392859d28397a3b0260fd7add1e776d965e9dc/testing/buildbot/filters/mash.ash_unittests.filter

Comment 3 by sky@chromium.org, Jun 6 2018

Status: Fixed (was: Started)

Sign in to add a comment